Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On x86-64 stack parameters must be in 8 byte slots #10

Closed
dibyendumajumdar opened this issue Feb 15, 2018 · 0 comments
Closed

On x86-64 stack parameters must be in 8 byte slots #10

dibyendumajumdar opened this issue Feb 15, 2018 · 0 comments
Labels
fixed

Comments

@dibyendumajumdar
Copy link
Owner

It appears that the when passing float or int parameters it is not always ensured that the stack slots are 8 bytes. A fix was partially applied in the FB fork for only the add_int() function, but similar fixes are needed in get_int(), add_float(), get_float().
dibyendumajumdar pushed a commit that referenced this issue Feb 15, 2018
issue #8 #10 ensure that on x86-64 when function parameters are passe…
9237fa7 
…d on the stack they are always at 8-byte boundaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dibyendumajumdar