Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integer Overflow in raviH_new_integer_array #208

Open
XmiliaH opened this issue Feb 13, 2021 · 1 comment
Open

Integer Overflow in raviH_new_integer_array #208

XmiliaH opened this issue Feb 13, 2021 · 1 comment
Labels
bug fixed

Comments

@XmiliaH
Copy link
Contributor

XmiliaH commented Feb 13, 2021

There is an integer overflow in raviH_new_integer_array at

ravi/src/ltable.c

Line 893 in 56a59a1

ravi_resize_array(L, t, len + 1, 0);

When the requested array size is 0xFFFFFFFF the array being allocated is of size 0 but the initialization will segfault as can be seen from running table.intarray(0xFFFFFFFF).

The same holds for the raviH_new_number_array function.
@dibyendumajumdar
Copy link
Owner

dibyendumajumdar commented Feb 13, 2021 •
edited
Loading

Thank you for the report

dibyendumajumdar added a commit that referenced this issue Feb 14, 2021
@dibyendumajumdar
issue #208 check for size overflow when creating integer/number array
8bd404f
dibyendumajumdar added a commit that referenced this issue Feb 14, 2021
@dibyendumajumdar
issue #208 add test
2c44bdd
dibyendumajumdar added a commit that referenced this issue Feb 16, 2021
@dibyendumajumdar
issue #208 check for overflow when resizing array
a3b933a
dibyendumajumdar added a commit that referenced this issue Feb 17, 2021
@dibyendumajumdar
issue #208 check for overflow when resizing array
4861459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dibyendumajumdar @XmiliaH