Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploded die with compare point or penetration has incorrect notation #16

Closed
GreenImp opened this issue Jan 9, 2017 · 0 comments
Closed
Assignees
Labels
bug modifier Dice modifier
Milestone

Comments

@GreenImp
Copy link
Collaborator

GreenImp commented Jan 9, 2017

If an exploding die has a compare point, and the dies didn't roll the maximum amount, the notation doesn't add the expected "!" mark.

ie.

1d6!>2: [5,3,6!,1] = 6

Should be:

1d6!>2: [5!,3!,6!,1] = 6

This also happens with penetrating dice:

ie.

1d6!p: [6!,5,3] = 14

Should be:

1d6!p: [6!,5!,3] = 14

Another case is where it doesn't explode, but the notation flags it as so. This happens when the compare point is lower than the max possible on the dice, and the max is rolled.

ie.

1d2!<2: [2!] = 2

Should be:

1d2!<2: [2] = 2

Unit test throws the following:

Expected "1d2!<2: [2!] = 2" to match parsed notation "1d2!<2: [2] = 2"

This is also apparent on compounding dice.

@GreenImp GreenImp added this to the 1.2.4 milestone Jan 9, 2017
@GreenImp GreenImp changed the title Exploding die with compare point notation incorrect Exploded die with compare point or penetration has incorrect notation Jan 9, 2017
@GreenImp GreenImp self-assigned this Feb 1, 2017
GreenImp added a commit that referenced this issue Feb 1, 2017
GreenImp added a commit that referenced this issue Feb 1, 2017
GreenImp added a commit that referenced this issue Feb 1, 2017
GreenImp added a commit that referenced this issue Feb 1, 2017
GreenImp added a commit that referenced this issue Feb 1, 2017
@GreenImp GreenImp closed this as completed Feb 1, 2017
@GreenImp GreenImp added the modifier Dice modifier label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug modifier Dice modifier
Projects
None yet
Development

No branches or pull requests

1 participant