Remove: @rollup/plugin-commonjs and fs-extra

dicebear · May 11, 2024 · a4f9dc1 · a4f9dc1
1 parent 52e9c89
commit a4f9dc1
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 96 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/@dicebear/collection/package.json b/packages/@dicebear/collection/package.json
@@ -52,15 +52,12 @@
   },
   "devDependencies": {
     "@dicebear/core": "^9.0.0-alpha.1",
-    "@rollup/plugin-commonjs": "^25.0.3",
     "@rollup/plugin-json": "^6.1.0",
-    "@rollup/plugin-node-resolve": "^15.0.1",
-    "@types/fs-extra": "^11.0.4",
+    "@rollup/plugin-node-resolve": "^15.2.3",
     "change-case": "^5.4.3",
     "del-cli": "^5.0.0",
-    "fs-extra": "^11.2.0",
     "glob": "^10.3.12",
-    "rollup": "^4.14.0",
+    "rollup": "^4.17.2",
     "tmp": "^0.2.1",
     "tsx": "^4.7.1",
     "webpack": "^5.76.3"

diff --git a/packages/@dicebear/collection/scripts/build-js.ts b/packages/@dicebear/collection/scripts/build-js.ts
@@ -2,8 +2,8 @@ import { glob } from 'glob';
 import { dirname, join, basename } from 'node:path';
 import { writeFile } from 'node:fs/promises';
 import { pascalCase } from 'change-case';
-import { ensureDir } from 'fs-extra';
 import { fileURLToPath } from 'node:url';
+import { Filesystem } from './helper/Filesystem.js';
 
 const __dirname = fileURLToPath(new URL('.', import.meta.url));
 const targetPath = join(__dirname, '..', 'lib');
@@ -42,7 +42,7 @@ export class ${className} extends Style {
 }
 `;
 
-  await ensureDir(dirname(styleClassTarget));
+  await Filesystem.ensureDir(dirname(styleClassTarget));
   await writeFile(styleClassTarget, styleClassContent);
 }
 

diff --git a/packages/@dicebear/collection/scripts/build-ts.ts b/packages/@dicebear/collection/scripts/build-ts.ts
@@ -2,9 +2,9 @@ import { glob } from 'glob';
 import { dirname, join, basename } from 'node:path';
 import { readFile, writeFile } from 'node:fs/promises';
 import { pascalCase } from 'change-case';
-import { ensureDir } from 'fs-extra';
 import { fileURLToPath } from 'node:url';
 import { Definition } from '@dicebear/core';
+import { Filesystem } from './helper/Filesystem.js';
 
 const __dirname = fileURLToPath(new URL('.', import.meta.url));
 const targetPath = join(__dirname, '..', 'lib');
@@ -82,7 +82,7 @@ export declare class ${className} extends Style<${className}Options> {
 }
 `;
 
-  await ensureDir(dirname(styleClassTarget));
+  await Filesystem.ensureDir(dirname(styleClassTarget));
   await writeFile(styleClassTarget, styleClassContent);
 }
 

diff --git a/packages/@dicebear/collection/scripts/helper/Filesystem.ts b/packages/@dicebear/collection/scripts/helper/Filesystem.ts
@@ -0,0 +1,10 @@
+import { existsSync } from 'node:fs';
+import { mkdir } from 'node:fs/promises';
+
+export class Filesystem {
+  static async ensureDir(path: string) {
+    if (!existsSync(path)) {
+      await mkdir(path, { recursive: true });
+    }
+  }
+}
diff --git a/packages/@dicebear/collection/tests/tree-shaking.rollup.test.js b/packages/@dicebear/collection/tests/tree-shaking.rollup.test.js
@@ -4,7 +4,6 @@ import { describe, it } from 'node:test';
 import { fileURLToPath } from 'url';
 import { rollup } from 'rollup';
 import { nodeResolve } from '@rollup/plugin-node-resolve';
-import commonjs from '@rollup/plugin-commonjs';
 import json from '@rollup/plugin-json';
 
 const __dirname = fileURLToPath(new URL('.', import.meta.url));
@@ -13,7 +12,7 @@ describe('rollup', () => {
   it('Tree shaking', async () => {
     const bundle = await rollup({
       input: `${__dirname}/fixtures/tree-shaking/index.js`,
-      plugins: [nodeResolve(), commonjs(), json()],
+      plugins: [nodeResolve(), json()],
     });
 
     const { output } = await bundle.generate({