Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Discord Mobile Video Embeded Res Bug #509

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fixed Discord Mobile Video Embeded Res Bug #509

merged 3 commits into from
Dec 12, 2023

Conversation

L7NEG
Copy link
Contributor

@L7NEG L7NEG commented Dec 9, 2023

before
After

Details: The Limited Embed Res On Discord Causes A Res Bug In Android Discord App
The Fix Is Just To Remove The <meta property='og:video:width' content='720' /> <meta property='og:video:height' content='480' /> and in the twitter card metatags too

fun fact twitter dosent have a res optimization like discord so the video embed wont be shown unless you let the twitter width one so i think this fix for discord only as it have res optimization

Changes Was Made From src\pages\view[id].tsx File

  • I Hope You Can Add An Auto res Fetch Feature To The Video Embed Like The Pics metatags One

@L7NEG
Copy link
Contributor Author

L7NEG commented Dec 9, 2023

or to make the same video embeded i copied the id.tsx file with its original embed value to a t folder for twitter embed like this ex https://i.l7neg.tk/t/Louca%20Incubada%20(slowed%20and%20reverb).mp4

Copy link
Owner

@diced diced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I forgot those width/height tags were even there lol

@L7NEG
Copy link
Contributor Author

L7NEG commented Dec 11, 2023

Thx bro ❤ xD

@diced diced merged commit b15390f into diced:trunk Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants