XTB: Support interest and fractional shares #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dickwolff
reviewed
Apr 19, 2024
src/converters/xtbConverter.ts
Outdated
| quantity: 1, | ||
| type: GhostfolioOrderType[record.type], | ||
| unitPrice: record.amount, | ||
| currency: process.env.XTB_ACCOUNT_CURRENCY, |
There was a problem hiding this comment.
Can you add a fallback to this? Like process.env.XTB_ACCOUNT_CURRENCY || “EUR”. I think currently Ghostfolio will not accept the export if you don’t provide a currency.
| @@ -1,4 +1,10 @@ | |||
| ID;Type;Time;Symbol;Comment;Amount | |||
| 530692719;Stocks/ETF purchase;12.04.2024 13:01:45;SPYL.DE;OPEN BUY 34/42.5658 @ 11.7480;-399.43 | |||
There was a problem hiding this comment.
Can you change the unit test to reflect the new lines that should be added?
|
Thanks for adding these changes @gabrielgradinaru, I left some remarks about a few changes I’d like you to make. The PR looks good to me except for those small changes! |
|
Sorry, I totally forgot about unit tests. I've fixed the xtb test and also updated yahoo-finance2 package because it was failing due to gadicc/node-yahoo-finance2#764 |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Add support in XTB for interest and fractional shares