Expose the underlying error message when the TP-Link API returns an unknown error #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the handling of unknown errors returned by TPLink, including the error message in the thrown error as well as the error code. Just seeing a code is rather opaque and you end up having to add debugging code into the library to actually see what came back. Exposing the message avoids this.
|
@dickydoouk Thanks for taking the time to build and publish this package! It's so great to see what the open source community can do ❤️ I'd love it if you'd take the time to review my proposed changes so we can make this project even better. P.S. I'd be happy to help you to maintain this library too, if you like! |
dickydoouk
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the handling of unknown errors returned by TPLink, including the error message in the thrown error as well as the error code.
Just seeing a code is rather opaque and you end up having to add debugging code into the library to actually see what came back. Exposing the message avoids this.