Skip to content

Commit

Permalink
Resolve race conditions during content loading when overriding suppor…
Browse files Browse the repository at this point in the history
…t files (#826)

Fixes the following issues:
- Some grammars importing the built-in Caster support file while only some importing The overridden one in the user directory

- Double imports, ( that is importing the same file under two different names) because some grammars will import the standard support file from the try branch while others From the except branch, raking havoc if support file contains some sort of mutable state
  • Loading branch information
mpourmpoulis committed Jun 30, 2020
1 parent 922ed43 commit 507fc13
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions castervoice/lib/ctrl/mgr/loading/load/content_loader.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def _process_requests(self, requests):
for request in requests:
if request.directory not in path:
path.append(request.directory)
for request in requests:
content_item = self.idem_import_module(request.module_name, request.content_type)
if content_item is not None:
result.append(content_item)
Expand Down

0 comments on commit 507fc13

Please sign in to comment.