update http module with requests, methods, and statuses #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
|
I can update docs if this changes is deemed acceptable. |
Jason2605
reviewed
Dec 26, 2021
| @@ -0,0 +1,3 @@ | |||
| import HTTP; | |||
|
|
|||
| assert(HTTP.STATUS_OK == 200); | |||
There was a problem hiding this comment.
Remember to add this file to: https://github.com/dictu-lang/Dictu/blob/develop/tests/http/import.du
Other than that looks fine to me! I wonder how we can add all of these to the docs without making the page too unmanageable.
There was a problem hiding this comment.
I took a stab at some verbiage to describe the added functionality in the docs. If you want it very explicit, I'm happy to do so.
There was a problem hiding this comment.
I'm pretty happy with that to be honest. I think listing out every constant on the page would be a bit much, thanks!
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brian Downs brian.downs@gmail.com
Well detailed description of the change :
Resolves:
Type of change:
Adds access to common headers, response codes, and messages.
Bug fix
New feature
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Housekeeping
Tests have been updated to reflect the changes done within this PR (if applicable).
Documentation has been updated to reflect the changes done within this PR (if applicable).
Preview (Screenshots) :