Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi followup: fixes the docs and moves the header into "include" #739

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

liz3
Copy link
Contributor

@liz3 liz3 commented Feb 20, 2024

ffi followup: fixes the docs and moves the header into "include"

Resolves: #738 (comment)

What's Changed:

I didn't expect the FFI pr to be merged already so heres a small follow up 😅

  • Update docs to be correct and link to the right places.
  • Update the docs to be exact
  • Move header into include folder.
  • Fix a logic bug in the ffi api version check

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@Jason2605
Copy link
Member

Appreciate the follow up! Ah yeah I had actually noticed the placeholders in the docs too 😓

All good though the docs don’t get built until we merge develop into master 😄

@liz3
Copy link
Contributor Author

liz3 commented Feb 20, 2024

This should be good now

Copy link
Member

@Jason2605 Jason2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@Jason2605 Jason2605 merged commit e43580d into dictu-lang:develop Feb 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants