-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support gnome-sdk for mesa #24
Conversation
- Move to core22 - use harfbuzz, freetype and alsa from libs - remove unnecessary dependencies
ping |
@lucyllewy, since this is a big change, I did some extra testing on mantic: amd64 builds and runs. arm64 on a M2 Air builds and runs (which uses the asahi channel track of the gnome extensions). arm64 on a Raspberry Pi 4 also builds and runs. |
Thanks for this. I'm sorry I took so long to get to it, but I'm checking it over now. |
many thanks. This looks good. |
amd64 Please let me know if I can relay anything to Canonical's snap team. |
supertuxkart: | ||
after: | ||
- freetype | ||
- harfbuzz | ||
plugin: cmake | ||
source: https://github.com/supertuxkart/stk-code/releases/download/$SNAPCRAFT_PROJECT_VERSION/SuperTuxKart-$SNAPCRAFT_PROJECT_VERSION-src.tar.xz | ||
override-pull: | | ||
snapcraftctl pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like this is the line causing the issue in the build service - it's saying we need to use craftctl default
.
I don't get why that is only affecting the build service tho, and then only the non-x86_64 build, when my local build on ARM64 worked just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the details 🙏
I messaged folks on Monday, but haven't heard back. Likely everyone is prepping for Riga, which will be a good opportunity to ask these questions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have a fix later today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucyllewy - do you mind posting the failing build logs? I was able to build on arm64 via snapcraft remote-build --build-for arm64
and I'm curious why it failed to build on snapcraft.io
I am currently working on getting more snaps working on arm64 laptops like Apple Silicon and the Lenovo x13s. Both of them use special mesa versions with drivers that aren't upstreamed yet. Our current snaps strategy is to have hardware specific channels of the gnome content snap that ship with the modified mesa version, see the -adreno and -asahi branches in https://github.com/ubuntu/gnome-sdk. In the future there might be a more general graphics plugin for that.
This PR makes Supertuxkart work with GPU acceleration on my M2 Air. While I was there I also simplified the build a bit and cleaned up the dependencies.
As I understand it the special handling for harfbuzz, freetype and alsa shouldn't be necessary anymore but let me know you'd like me to keep them.