fix:修复笔记本触摸板点击节点事件失效 #1465
Merged
fix:修复笔记本触摸板点击节点事件失效 #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复issue#1071：笔记本触摸板点击节点时并没有触发node:click事件。
原代码判断逻辑为：mousedown和click间隔时间大于200ms，则认为是拖拽，不触发click事件。
这样判断并不是最优方式， 原因：
1.当使用触摸板点击时，时间间隔大于200ms，具体是210ms-240ms之间，导致没有触发node:click事件。
2.当单次拖拽操作很短的情况下（在200ms内），按照原代码，会触发node:click事件，这与期望不符。
本次提交的改动：对节点增加mouseup监听，对拖拽状态isDragging状态进行记录，在handleClick中进行判断，确保在鼠标及触摸板点击时都能正常触发node:click事件。