Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增量编译时对 jar 处理的问题 #406

Closed
woyelaishishiba opened this issue Mar 18, 2023 · 2 comments
Closed

增量编译时对 jar 处理的问题 #406

woyelaishishiba opened this issue Mar 18, 2023 · 2 comments

Comments

@woyelaishishiba
Copy link

woyelaishishiba commented Mar 18, 2023

com.didiglobal.booster.gradle.BoosterTransformInvocation 中的 doIncrementalTransform(jarInput: JarInput) 在对增量编译的 jar 处理时删除了 jarInput,我理解删除的应该是 jar 的 output,否则升级 jar 后增量编译时会出现类冲突的问题。

预期将 jarInput.status == REMOVED 的处理从
jarInput.file.delete()
修改为

outputProvider?.let { provider ->
    provider.getContentLocation(
        jarInput.id, jarInput.contentTypes, jarInput.scopes, Format.JAR
    )?.takeIf { it.exists() }?.delete()
}
@johnsonlee
Copy link
Collaborator

直接提个 PR ?

johnsonlee added a commit to johnsonlee/booster that referenced this issue Apr 6, 2023
@johnsonlee
Copy link
Collaborator

released in v4.16.0-alpha2

johnsonlee added a commit to johnsonlee/booster that referenced this issue May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants