Monitor can't connect to screenly API when screenli OSE is set to use SSL / 301 Redirect

[LeSnowTiger]

Your issue may already be reported!
Please search on the issue tracker before creating one.

Expected Behavior

It's possible to set screenly ose to use SSL. When the player is set to SSL its not possible to connect the player with the monitor.

Current Behavior

The monitor runs in a HTTP 301 redirect and throws an error.

Possible Solution

I'm not sure if this is a good fix but it works.

https://github.com/didiatworkz/screenly-ose-monitor/blob/e157f34aa61223a7b0a5da77996f1f5d63111685/assets/php/player.php#L123

to

if(($httpcode>=200 && $httpcode<300) || $httpcode==401 || $httpcode==301) return true;

And
https://github.com/didiatworkz/screenly-ose-monitor/blob/e157f34aa61223a7b0a5da77996f1f5d63111685/assets/php/image.php#L30

to
if(($httpcode>=200 && $httpcode<300) || $httpcode==401 || $httpcode==301) return true;

Steps to Reproduce (for bugs)

1. Set Player to use SSL. (Run /screenly/bin/enable_ssl.sh)
2. Add the Player
3. Error Occurs and Image is Offline

Context

HTTPS did not work.

Your Environment

• Screenly OSE Monitoring Version: v3.3
• Screenly OSE Version: production@d12df55
• Raspbian Version: Buster
• Browser Name and version: Chrome 86.0.4240.75
• Operating System and version (desktop or mobile): Desktop

[didiatworkz]

Hello @LeSnowTiger

First: Great that you took the time to analyze the problem and suggest a solution!
I just set up a test system and was able to reproduce your problem.
I will implement your solution within the next days. Maybe I have some time to fix some other problems. - I put the whole thing on my to-do list.
Thank you 😄

[LeSnowTiger]

I'm glad I could help :)