Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a memory leak #44

Merged
merged 1 commit into from
May 10, 2018
Merged

fixed a memory leak #44

merged 1 commit into from
May 10, 2018

Conversation

hansoksendahl
Copy link

The library had a subscribe method but no unsubscribe method.

@coveralls
Copy link

coveralls commented May 5, 2018

Pull Request Test Coverage Report for Build 27

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 22: 0.0%
Covered Lines: 40
Relevant Lines: 40

💛 - Coveralls

@didierfranc didierfranc self-requested a review May 6, 2018 16:54
@didierfranc
Copy link
Owner

Not really a memory leak but unsuscribe could be useful !

@hansoksendahl
Copy link
Author

hansoksendahl commented May 6, 2018

It is most certainly a memory leak. There is an array managed by the library which allows you to add entries to it with no ability to remove them or clear the array. A thank you would suffice.

@hansoksendahl hansoksendahl mentioned this pull request May 6, 2018
@shahruz
Copy link

shahruz commented May 9, 2018

@didierfranc are there plans for this to be merged in?

@didierfranc didierfranc merged commit 0ceceae into didierfranc:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants