support sending per-job arguments #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 4370e87 on n3bulous:support-passing-job-arguments-per-job into * on didil:master*. |
|
Changes Unknown when pulling 555e652 on n3bulous:support-passing-job-arguments-per-job into * on didil:master*. |
|
@coveralls @n3bulous This looks good, can you merge this? |
|
@didil That looks good, can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the need to pass arguments to my jobs so I added the functionality. I started off writing my own Regex to parse the parameters, then remembered that Rake did this also. Jim's Regex's were a little more complex, but look like they are more exacting than mine, so I grabbed his parse_task_string method.
Cheers,
Kevin