Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a retry option #4

Closed
wants to merge 1 commit into from

Conversation

codebender
Copy link
Contributor

Hi @didil,

So I consolidated my previous attempt (#3) to one option:

-retry false or -r false - Tells Sidekiq to not retry the job, if the job fails
-retry 5 or -r 5 - Tells Sidekiq to retry the job at most 5 times, if the job fails

This now mimics the options of sidekiq's advanced options (https://github.com/mperham/sidekiq/wiki/Advanced-Options#workers)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling ba5f6d0 on MisterBender:feature/add_retry_arg into 01b343c on didil:master.

@didil
Copy link
Owner

didil commented Oct 4, 2013

Thanks but we've had to modify the way the default options are handled due to a breaking change in sidekiq 2.15.0 so that conflicts with your pull request, please have a look at the current master, pull it, make the changes and send a new pull request, it should be quick

@didil didil closed this Oct 4, 2013
@codebender codebender mentioned this pull request Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants