Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape "|" in Table.create_table #63

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Escape "|" in Table.create_table #63

merged 2 commits into from
Oct 18, 2021

Conversation

jaredliw
Copy link
Contributor

No description provided.

@didix21
Copy link
Owner

didix21 commented Oct 16, 2021

Please can you rebase didix21:master?

@didix21
Copy link
Owner

didix21 commented Oct 16, 2021

I'm wondering why you have to scape '|'?

@jaredliw
Copy link
Contributor Author

I'm wondering why you have to scape '|'?

Table columns are seperated by |, if the list of strings contains |, the table will be malformed. If it is in the header row, the table is shown as raw text. If it is in the body row, the last cell of the row is ignored.

I dont expect this behavior, i think i should be a bug.

@jaredliw
Copy link
Contributor Author

Btw, what about \n? It should be the same case.

I faced this when I am handling articles' titles, i submit this pr immediately, didnt think quite much beyond that...

@jaredliw
Copy link
Contributor Author

Please can you rebase didix21:master?

Wait a sec, i will do that

@didix21
Copy link
Owner

didix21 commented Oct 18, 2021

Seems tests are not running after the rebase. Let me close pull request and open it again.

@didix21 didix21 closed this Oct 18, 2021
@didix21 didix21 reopened this Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #63 (e70c8c6) into master (c7c119c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files          13       13           
  Lines         462      462           
  Branches       81       81           
=======================================
  Hits          395      395           
  Misses         45       45           
  Partials       22       22           
Impacted Files Coverage Δ
mdutils/tools/Table.py 90.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c119c...e70c8c6. Read the comment docs.

@didix21 didix21 self-requested a review October 18, 2021 22:07
@didix21 didix21 added the bug Something isn't working label Oct 18, 2021
@didix21 didix21 merged commit 9cc2a5c into didix21:master Oct 18, 2021
@jaredliw
Copy link
Contributor Author

Thanks, have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants