Update API response types #15
Conversation
… added comments where meaningful)
|
@didoo i dont have much time to maintain figma-api actually |
|
@Morglod I didn't mean you had to do it, maybe I can (if you think you have time to at least merge the PRs). |
|
@didoo ye, I can review PRs with no problem or transfer ownership; also do some tasks if you plan & structure it |
if it's ok for you, transfer ownership (also on npm) would be great! as I told you, I have some spare time to spend on this. and all the help is welcome, of course :) |
|
@didoo Looks like easier to stay as it was and I just fast-review & merge everything from you |
|
@Morglod sorry, my bad, I didn't think of the name conflict with my fork 🤦♂️. Now I have renamed the fork, it should be ok to transfer it. |
|
@didoo |
OK, I have completely deleted the fork. Try now, it should work 🤞 |
|
@Morglod one last thing: can you transfer also the package on NPM? So I can publish it on the public repository too: (my user is "didoo") |
Comparing the types declared in the
apy-types.dsfile and the ones described on the Figma.com website, I have noticed there are some differences, expecially for the "Components and styles" group.In this PR I have updated the types definition. Please double check that everything is OK. (*)
Also, I have noticed that some of the definitions for the "Figma files" group are slightly different, but I don't know them enough to be confident to change them, in case you know better please update them as well.
* it would be great to have some form of tests, so it's safer to do some code refactoring like this, without worrying to break something, maybe I'll open a PR to discuss some ideas that I have about it.