Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade to latest cloudcontroller (openapi v7.4.0) #734

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented Apr 4, 2024

Newly generated cloudcontroller, upgrades from openapi-generator v7.0 to v7.4
didx-xyz/aries-cloudcontroller-python#164

Changes to openapi spec:

  • many model fields now come with a description
  • some model types are corrected to being "objects" / dictionaries, instead of strings or objects. Affected models:
    • ClaimFormat, used in the PresentationDefinition model
    • credentialSubject, used in the Credential model
    • record_ids and reveal_doc, used in the DIFPresSpec model
    • metadata, in the InputDescriptors model
    • signed_doc, in the SignResponse model
    • cred_value, in the VCRecord model
  • (to reiterate, all of the above fields are now correctly shown as only Dictionary / Object types, and not Objects OR Strings)

@ff137 ff137 changed the title 🚧 Test latest cloudcontroller 🚧 Test upgraded cloudcontroller (openapi-generator-7.4.0) Apr 4, 2024
@ff137 ff137 self-assigned this Apr 4, 2024
@ff137 ff137 added the dependencies Pull requests that update a dependency file label Apr 4, 2024
@ff137 ff137 marked this pull request as draft April 4, 2024 17:56
@ff137 ff137 force-pushed the upgrade/new-cloudcontroller branch from edfd6c7 to 1d5581c Compare April 16, 2024 09:56
@ff137 ff137 marked this pull request as ready for review April 16, 2024 10:49
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
app
   main.py802668%81–84, 108, 110, 112, 116, 123, 149–154, 161–188
app/dependencies
   acapy_clients.py24196%52
   auth.py561868%31, 37–38, 41, 52–55, 62–63, 68, 74–79, 83–86, 90–91
   role.py34197%56
app/models
   issuer.py48296%35, 44
   jsonld.py35586%21, 45–50
   oob.py24196%26
   tenants.py781186%75, 78, 89, 94, 106, 109, 128–138
   verifier.py65691%34, 42, 53, 61, 101, 110
app/routes
   connections.py603935%32–48, 64–76, 113–138, 159–173, 188–199
   definitions.py1889251%76–137, 170–171, 238–254, 269–275, 296–305, 328–329, 346–348, 391–445, 472–473, 517–597, 605–624
   issuer.py1733878%92, 128, 167–169, 198, 234–236, 244, 261, 360–370, 401–412, 445–476, 517, 530, 562
   jsonld.py604722%23–93, 104–137
   messaging.py241154%32–41, 61–71
   oob.py462839%27–68, 79–92, 116–127
   verifier.py1463278%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–211, 220–222, 272–274, 280, 313–315, 320, 350–352, 386–388
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py762271%28–37, 56–57, 79–80, 92–99, 107–115
   jws.py422736%35–60, 76–99
   sd_jws.py422736%36–61, 78–101
app/services
   acapy_ledger.py611280%110–111, 124–140, 196–197
   acapy_wallet.py39490%60–61, 97–98
   revocation_registry.py1301291%309–313, 341, 351–353, 383–387, 412–417
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py921485%36, 76–110, 213–214
   acapy_issuer_v2.py1062279%60–63, 87–127, 173, 235–236, 263
app/services/onboarding
   tenants.py584424%30–97, 107–137
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py693746%28–30, 50–52, 76–78, 109–128, 140–149, 161–172, 185–197
app/services/trust_registry
   actors.py107992%94–99, 109, 208–209, 211–216, 281–284
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%43–51
   test_jsonld.py591673%133–168
   test_tenants.py3341596%167, 211–212, 240, 665, 699–700, 709–710, 719–720, 732–733, 742–743
   test_wallet_dids.py671085%92–107
app/tests/e2e/issuer
   test_save_exchange_record.py59198%141
app/tests/e2e/verifier
   test_verifier.py401199%1090
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/services
   test_revocation_registry.py135299%73, 106
app/tests/services/issuer
   test_issuer.py161299%316–319
app/tests/util
   credentials.py56198%153
   ecosystem_connections.py1332780%311–330, 347–367, 375–414
   ledger.py491080%34, 42, 54, 62–66, 76, 82
   member_acapy_clients.py36489%47–50, 73–74
   sse_listener.py41880%50–55, 79–84
   trust_registry.py42393%27, 30–31
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 189–192, 269
   credentials.py11464%11, 15–18
   retry_method.py361558%20–35, 76–77, 91–103
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
trustregistry
   db.py29969%11–15, 19–23
   list_type.py11464%11–14, 17
   main.py411563%23–32, 54–59, 64
trustregistry/registry
   registry_actors.py82199%55
webhooks/models
   conversions.py63690%70, 83, 89, 110, 145, 163
webhooks/services
   acapy_events_processor.py1751591%95, 158–168, 216–220, 248, 276–277, 305–309, 321–325
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py122497%66, 233–234, 350
webhooks/tests/services
   test_sse_manager.py180398%212–213, 219
webhooks/web/routers
   sse.py102397%168–171
TOTAL12204100792% 

Tests Skipped Failures Errors Time
735 8 💤 0 ❌ 0 🔥 11m 45s ⏱️

@ff137 ff137 changed the title 🚧 Test upgraded cloudcontroller (openapi-generator-7.4.0) ⬆️ Upgrade to latest cloudcontroller Apr 16, 2024
@ff137 ff137 force-pushed the upgrade/new-cloudcontroller branch from a037401 to c070f40 Compare April 16, 2024 15:31
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
app
   main.py802668%81–84, 108, 110, 112, 116, 123, 149–154, 161–188
app/dependencies
   acapy_clients.py24196%52
   auth.py561868%31, 37–38, 41, 52–55, 62–63, 68, 74–79, 83–86, 90–91
   role.py34197%56
app/models
   issuer.py48296%35, 44
   jsonld.py35586%21, 45–50
   oob.py24196%26
   tenants.py781186%75, 78, 89, 94, 106, 109, 128–138
   verifier.py65691%34, 42, 53, 61, 101, 110
app/routes
   connections.py603935%32–48, 64–76, 113–138, 159–173, 188–199
   definitions.py1889251%76–137, 170–171, 238–254, 269–275, 296–305, 328–329, 346–348, 391–445, 472–473, 517–597, 605–624
   issuer.py1733878%92, 128, 167–169, 198, 234–236, 244, 261, 360–370, 401–412, 445–476, 517, 530, 562
   jsonld.py604722%23–93, 104–137
   messaging.py241154%32–41, 61–71
   oob.py462839%27–68, 79–92, 116–127
   verifier.py1463278%64–66, 71, 109–111, 116, 158, 166–168, 173, 207–211, 220–222, 272–274, 280, 313–315, 320, 350–352, 386–388
   webhooks.py16475%32–36, 57–61
   websocket_endpoint.py23865%24–25, 37–42, 54–57, 70–76
app/routes/wallet
   credentials.py775232%32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
   dids.py762271%28–37, 56–57, 79–80, 92–99, 107–115
   jws.py422736%35–60, 76–99
   sd_jws.py422736%36–61, 78–101
app/services
   acapy_ledger.py611280%110–111, 124–140, 196–197
   acapy_wallet.py39490%60–61, 97–98
   revocation_registry.py1301291%309–313, 341, 351–353, 383–387, 412–417
   webhooks.py271833%17–25, 29–39
   websocket.py514120%19–22, 29–36, 47–91
app/services/event_handling
   websocket_manager.py732664%64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
   acapy_issuer_v1.py921485%36, 76–110, 213–214
   acapy_issuer_v2.py1062279%60–63, 87–127, 173, 235–236, 263
app/services/onboarding
   tenants.py584424%30–97, 107–137
   verifier.py37392%67, 83–87
app/services/onboarding/util
   register_issuer_did.py86397%100–102
   set_endorser_metadata.py693746%28–30, 50–52, 76–78, 109–128, 140–149, 161–172, 185–197
app/services/trust_registry
   actors.py107992%94–99, 109, 208–209, 211–216, 281–284
   schemas.py49492%56–61, 91–96
app/services/trust_registry/util
   actor.py31294%26–27
   issuer.py23483%39–40, 48–49
app/tests/e2e
   conftest.py23578%43–51
   test_jsonld.py591673%133–168
   test_tenants.py3341596%167, 211–212, 240, 665, 699–700, 709–710, 719–720, 732–733, 742–743
   test_wallet_dids.py671085%92–107
app/tests/e2e/issuer
   test_save_exchange_record.py59198%141
app/tests/e2e/verifier
   test_verifier.py401199%1090
app/tests/exception_handling
   test_handle_model_with_validation.py23196%22
app/tests/services
   test_revocation_registry.py135299%73, 106
app/tests/services/issuer
   test_issuer.py161299%316–319
app/tests/util
   credentials.py56198%153
   ecosystem_connections.py1332780%311–330, 347–367, 375–414
   ledger.py491080%34, 42, 54, 62–66, 76, 82
   member_acapy_clients.py36489%47–50, 73–74
   sse_listener.py41880%50–55, 79–84
   trust_registry.py42393%27, 30–31
   webhooks.py45491%19, 74–77, 100
app/util
   acapy_issuer_utils.py18194%22
   acapy_verifier_utils.py137596%108–111, 189–192, 269
   credentials.py11464%11, 15–18
   retry_method.py361558%20–35, 76–77, 91–103
   tenants.py451762%24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
   endorsement_processor.py137696%90, 152–162
trustregistry
   db.py29969%11–15, 19–23
   list_type.py11464%11–14, 17
   main.py411563%23–32, 54–59, 64
trustregistry/registry
   registry_actors.py82199%55
webhooks/models
   conversions.py63690%70, 83, 89, 110, 145, 164
webhooks/services
   acapy_events_processor.py1862288%98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
   billing_manager.py175498%91, 98–99, 132
   sse_manager.py2353685%153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
   webhooks_redis_service.py1401986%70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
   test_sse_manager.py180398%211–212, 218
webhooks/web/routers
   sse.py102397%168–171
TOTAL12667103392% 

Tests Skipped Failures Errors Time
782 8 💤 0 ❌ 0 🔥 11m 39s ⏱️

@ff137 ff137 requested a review from cl0ete April 17, 2024 08:28
@ff137 ff137 merged commit 86b52b0 into development Apr 17, 2024
44 checks passed
@ff137 ff137 deleted the upgrade/new-cloudcontroller branch April 17, 2024 08:54
@ff137 ff137 changed the title ⬆️ Upgrade to latest cloudcontroller ⬆️ Upgrade to latest cloudcontroller (openapi v7.4.0) Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants