Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw errors when the response throws and error #68

Closed
TimoGlastra opened this issue Nov 10, 2021 · 2 comments
Closed

Throw errors when the response throws and error #68

TimoGlastra opened this issue Nov 10, 2021 · 2 comments

Comments

@TimoGlastra
Copy link
Collaborator

Currently when a request fails it won't throw an error. This makes it hard to detect what went wrong (404, 500, etc...). I'd like to add some error handling decorators to the API: https://uplink.readthedocs.io/en/stable/user/quickstart.html#response-and-error-handling

@TimoGlastra
Copy link
Collaborator Author

I was wrong. Uplink does throw errors, ACA-Py doesn't throw an error when the schema is not found, but returns 200 with an empty schema object

@TimoGlastra
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant