Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACA-Py returns 200 with "schema": null when no schema found #1487

Closed
TimoGlastra opened this issue Nov 10, 2021 · 2 comments · Fixed by #2683
Closed

ACA-Py returns 200 with "schema": null when no schema found #1487

TimoGlastra opened this issue Nov 10, 2021 · 2 comments · Fixed by #2683
Assignees

Comments

@TimoGlastra
Copy link
Member

When a schema is not found when calling the /schemas/{schema_id} endpoint, ACA-Py returns the following json with a 200 response code.

{
  "schema": null
}

Shouldn't this return a 404 error? Or is this on purpose? Not sure how things not found on the ledger should be processed

@swcurran
Copy link
Member

swcurran commented Jun 3, 2022

@ianco @andrewwhitehead -- could you please weigh in on this? Should we change ACA-Py for this case?

Or should we just close this issue as a ¯\_(ツ)_/¯?

@ianco
Copy link
Member

ianco commented Jun 3, 2022

I think it makes sense to return a 404

@jamshale jamshale self-assigned this Dec 18, 2023
@jamshale jamshale linked a pull request Dec 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants