Pinning a certain certificate in the chain #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am submitting a pull request to pin a specific certificate in the certificate chain.
I decided to expand the original library in order to support the root/intermediate certificate pinning, which might be a use-case needed by some people/users (for example myself).
Instead of just forking it for me and my team I think it would also be helpful if we can add it to the original library for the entire Flutter community.
The main change is a new parameter in the
checkmethod calledindex.I defined it as a nullable Int in order to support the retro compatibility.
The native implementation take it as 0 in case is not passed (as was doing before) in order to pin the leaf (same behaviour as before).
I'm not the best kotlin/swift dev out there so I am open to any suggestion to improve the codebase before having my PR approved.