-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tmux and screen sessions. Resolves #50 #52
Conversation
Hello, thank you for your PR but I am afraid it is far from ready. Let me go through some points.
I know this information should be written somewhere and that is something that I have to do. Now, regarding the PR:
|
Thanks for the comments @diego-treitos . I will make the changes and push them. |
One small confusion, as u are asking to make the sof535 as sof040 and level 2. Since all level 2 tests are above 500, it will be a contradiction now!? |
You are absolutely right. It shouldn't be |
cool! Also, is there any rule for IDs of level 1 tests? |
Both the suggested level 2 tests are only checking whether they are installed or not. Won't it be more reasonable to keep these 2 tests as level 0/1 and the socket tests as level 1/2 ? |
Level Level Level |
I got ur point now. Making sense this way.. |
I am merging this but I will apply some changes later. The PR itself is quite inconsistent:
|
Also, next time please test the tests. There were several that were not working. Thank you |
Thanks for telling the mistakes. I will make another commit+PR to correct them. |
Can you please tell me which ones? I actually ran then before pushing. |
|
Added level 0 testing for tmux and screen