feat(connection actions): add context menu for connection actions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the options menu for when the user clicks with the right mouse button in a connection. re diego3g#37
natanaelsirqueira
changed the title
yzevm
reviewed
Jul 17, 2020
|
Can you apply the i18n messages as we merged #57? |
|
I'm on it! |
|
@natanaelsirqueira I'm fixing some problems with the i18n, so you can wait until i merge #73 so we'll have this part fixed. |
|
I was just about to comment that I've experienced some weird behavior with the translations. 😄 Thanks for letting me know. |
diego3g
requested changes
Jul 19, 2020
There was a problem hiding this comment.
Great job @natanaelsirqueira, i just left some suggestions to keep the code cleaner but feel free to discuss with me the points you think that are not necessary right now.
Also, if you could fix the conflicts after this, it would be great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the options menu for when the user clicks with the right mouse button in a connection.
Connect/Disconnect
Refresh
Edit
Delete
fix #37