Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: autocomplete component: The computed property "fields" is already defined as a prop. #118

Closed
2 tasks done
websitevirtuoso opened this issue Nov 23, 2020 · 22 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working solved The problem presented is considered solved and the issue closed
Projects

Comments

@websitevirtuoso
Copy link

websitevirtuoso commented Nov 23, 2020

Describe the bug
A clear and concise description of what the bug is.
I am trying to migrate from old vue-gmap plugin to your lib. Got this error
My application using vuetify. Somewhere creating a computed property with the name "fields".
I don't know where but know that your plugin doing the same.
SO I got next error:

`
[Vue warn]: The computed property "fields" is already defined as a prop.

found in

---> at node_modules/gmap-vue/dist/components/autocomplete.vue

at src/views/property/Create.vue

at src/components/layout/Index.vue

at src/App.vue

`

Expected behaviour
Should work without error The computed property "fields" is already defined as a prop.

Current behaviour
Display error: The computed property "fields" is already defined as a prop.

Desktop:

  • OS: Ubuntu 19.04
  • Browser chrome
  • Version 86.0.4240.198

Versions

  • Node: 12
  • NPM: 6.14.9

Package manager

  • NPM

Plugin version

  • 1.5.0
@websitevirtuoso websitevirtuoso added the bug Something isn't working label Nov 23, 2020
@close-issue-app
Copy link

This issue is closed because it does not meet our issue template. Please read it.

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 23, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@websitevirtuoso
Copy link
Author

@diegoazh

@diegoazh
Copy link
Owner

diegoazh commented Nov 24, 2020

@websitevirtuoso can you rewrite this issue but please you don't need to paste your package.json in the issue template because the boot will close your issue, because it doesn't follow our issue template if you want to paste it please leave it in a comment after creating the issue.
Another option is to fix this issue and leave a comment here and after that, I can reopen this issue and the bot will not close it anymore.

@websitevirtuoso
Copy link
Author

Package json

`
{
"name": "ecom-dashboard",
"version": "0.1.0",
"private": true,
"scripts": {
"serve": "vue-cli-service serve",
"build": "vue-cli-service build && rm -rf ./dist/**/*.js.map",
"lint": "vue-cli-service lint",
"apollo": "vue-cli-service apollo:watch",
"apollo:run": "vue-cli-service apollo:run"
},
"dependencies": {
"@casl/ability": "^4.1.6",
"@casl/vue": "^1.1.1",
"@sentry/browser": "^5.27.4",
"@sentry/integrations": "^5.27.4",
"@sentry/webpack-plugin": "^1.13.0",
"core-js": "^3.7.0",
"cropperjs": "^1.5.9",
"gmap-vue": "^1.5.0",
"graphql-type-json": "^0.3.2",
"ramda": "^0.27.1",
"tiptap-vuetify": "^2.24.0",
"vee-validate": "^2.2.15",
"vue": "^2.6.12",
"vue-2-crumbs": "^0.5.4",
"vue-apollo": "^3.0.5",
"vue-moment": "^4.1.0",
"vue-router": "^3.4.9",
"vuedraggable": "^2.24.3",
"vuetify": "^2.3.18",
"vuex": "^3.5.1",
"vuex-i18n": "^1.13.1"
},
"devDependencies": {
"@babel/core": "^7.12.7",
"@babel/eslint-parser": "^7.12.1",
"@mdi/font": "^5.8.55",
"@vue/cli-plugin-babel": "^4.5.9",
"@vue/cli-plugin-eslint": "^4.5.9",
"@vue/cli-service": "^4.5.9",
"@vue/eslint-config-standard": "^5.1.2",
"eslint": "^7.14.0",
"eslint-plugin-graphql": "^4.0.0",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-standard": "^4.1.0",
"eslint-plugin-vue": "^7.1.0",
"graphql-tag": "^2.11.0",
"sass": "^1.29.0",
"sass-loader": "^10.1.0",
"vue-cli-plugin-apollo": "^0.21.3",
"vue-cli-plugin-vuetify": "^2.0.7",
"vue-template-compiler": "^2.6.12",
"vuetify-loader": "^1.6.0",
"webpack-bundle-analyzer": "^4.1.0"
},
"engines": {
"node": ">= 10.0.0",
"npm": ">= 6.8.0"
}
}

`

@websitevirtuoso
Copy link
Author

@diegoazh Thanks for help. I changed message to your template/ Let me know if it works

@stale
Copy link

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 20, 2021
@stale stale bot closed this as completed Mar 27, 2021
@julienperrault
Copy link

I've the same problem.
image

I'm using pug, so that's is my component (with no customs props).

<template lang="pug">
    gmap-autocomplete
</template>

@websitevirtuoso
Copy link
Author

@julienperrault I had to fork and fix it. Almost all issues bot closing. very sad

@diegoazh diegoazh reopened this Nov 18, 2021
@stale stale bot removed the wontfix label Nov 18, 2021
@diegoazh
Copy link
Owner

@julienperrault sorry about that, the bot causes many problems, test the new version 2.0.0 and check the new documentation page to, please let me know if the issue persists @websitevirtuoso all components are working well in the documentation.

@diegoazh diegoazh added the needs more info The maintainers asked questions that require answers or ask to test some possible solutions label Nov 26, 2021
@diegoazh diegoazh self-assigned this Nov 26, 2021
@create-issue-branch
Copy link

@diegoazh diegoazh added this to To do in gmap-vue via automation Nov 26, 2021
@diegoazh
Copy link
Owner

@julienperrault about the bot, please try to open a new issue for test and check if the bot works correctly now, I do that and works well for me but I'm not completely sure if it is fixed or not.

@stale
Copy link

stale bot commented Jan 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 26, 2022
@stale stale bot closed this as completed Feb 3, 2022
gmap-vue automation moved this from To do to Done Feb 3, 2022
@diegoazh
Copy link
Owner

@websitevirtuoso @julienperrault can you test the last v2.0.3 and let me know if the bug persists.

@diegoazh diegoazh reopened this Feb 11, 2022
gmap-vue automation moved this from Done to In progress Feb 11, 2022
@stale stale bot removed the wontfix label Feb 11, 2022
@razukc
Copy link

razukc commented Feb 11, 2022

@websitevirtuoso @julienperrault can you test the last v2.0.3 and let me know if the bug persists.

I've tested it. The issue still exists.
image

@diegoazh
Copy link
Owner

Can you share with me you component @razukc? to reproduce the issue locally, thanks.

github-actions bot pushed a commit that referenced this issue Feb 11, 2022
## [2.0.4](v2.0.3...v2.0.4) (2022-02-11)

### Bug Fixes

* **gmap-vue:** fix fields error on autocomplete component ([a6b8712](a6b8712)), closes [#118](#118)
@diegoazh
Copy link
Owner

I think is fixed on v2.0.4 can you confirm that @razukc?

@diegoazh diegoazh added solved The problem presented is considered solved and the issue closed waiting for feedback and removed needs more info The maintainers asked questions that require answers or ask to test some possible solutions solved The problem presented is considered solved and the issue closed labels Feb 11, 2022
@razukc
Copy link

razukc commented Feb 15, 2022

I think is fixed on v2.0.4 can you confirm that @razukc?

I tested it and I confirm that it is working. But for some reason, yarn add gmap-vue is installing gmap-vue@3.0.0. However, the warning is gone now. @diegoazh

@diegoazh
Copy link
Owner

Excellent @razukc I'll mark this issue as solved. The v3.0.0 is the last one that I land a few days ago and more changes are coming.

@diegoazh diegoazh added solved The problem presented is considered solved and the issue closed and removed waiting for feedback labels Feb 15, 2022
gmap-vue automation moved this from In progress to Done Feb 15, 2022
@dhcmega
Copy link

dhcmega commented Mar 12, 2022

Hi, I'm on 2.0.4 with "@googlemaps/markerclusterer": "^1.0.26", and I'm getting this same error: TypeError: this.$clusterObject.repaint

Is this only fix on v3 or also for v2?
thanks

@diegoazh
Copy link
Owner

Hi, that bug was fixed on version 3.

@dhcmega
Copy link

dhcmega commented Mar 13, 2022

I don't know why I thought v3 was for vue v3. It worked right away. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working solved The problem presented is considered solved and the issue closed
Projects
No open projects
gmap-vue
  
Done
Development

No branches or pull requests

5 participants