Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add overlaycomplete, fillColor, strokeColorstrokeColor props for DrawingManager #138

Closed
akorajac opened this issue Jan 17, 2021 · 5 comments · Fixed by #253
Closed
Assignees
Labels
enhancement Improve an existing functionality requested for the community released
Projects

Comments

@akorajac
Copy link

akorajac commented Jan 17, 2021

Is your feature request related to a problem? Please describe.
For the moment when you complete/deselect/select, let's say a polygon, it will automatically go back to the colors set in /components-implementation/drawing-manager.js/ on clearSelection() and setSelection().
It overwrites the options you set in (ex.):

polylineOptions: {
        fillColor: "#ff0000",
        fillOpacity: 0.7,
        strokeWeight: 2,
        strokeColor: "#ff0000",
        draggable: false,
        editable: false,
        clickable: true,
      },

Describe the solution you'd like
If possible add props.

Describe alternatives you've considered
For the moment I am doing this:

mounted() {
    setTimeout(() => {
      this.$refs.drawmanager.$drawingManagerObject.addListener(
        "overlaycomplete",
        (event) => {
          this.myFunction();
        }
      );
    }, 1000);
  },

Additional context

@akorajac akorajac added the feature requested A new feature requested for the community label Jan 17, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 19, 2021
@stale stale bot closed this as completed Mar 26, 2021
@diegoazh diegoazh reopened this Nov 18, 2021
@stale stale bot removed the wontfix label Nov 18, 2021
@diegoazh diegoazh self-assigned this Nov 26, 2021
@create-issue-branch
Copy link

@diegoazh diegoazh added this to To do in gmap-vue via automation Nov 26, 2021
@stale
Copy link

stale bot commented Jan 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 26, 2022
@stale stale bot closed this as completed Feb 3, 2022
gmap-vue automation moved this from To do to Done Feb 3, 2022
@diegoazh diegoazh reopened this Feb 11, 2022
gmap-vue automation moved this from Done to In progress Feb 11, 2022
@stale stale bot removed the wontfix label Feb 11, 2022
@diegoazh
Copy link
Owner

@akc4 can you check the new v2.0.3 and let me know if those options are not present, in some cases we give an options prop to use for that options that are not commonly used but that will be possible that someone needs on some cases.

@diegoazh diegoazh added WIP work in progress enhancement Improve an existing functionality requested for the community and removed feature requested A new feature requested for the community labels Feb 16, 2022
gmap-vue automation moved this from In progress to Done Feb 19, 2022
@diegoazh diegoazh removed the WIP work in progress label Feb 19, 2022
github-actions bot pushed a commit that referenced this issue Feb 19, 2022
## [3.4.2](v3.4.1...v3.4.2) (2022-02-19)

### Bug Fixes

* **gmap-vue:** add missing props to all shapes for drawing over the map ([c39c500](c39c500)), closes [#138](#138)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing functionality requested for the community released
Projects
No open projects
gmap-vue
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants