Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-model on marker #14

Closed
josegus opened this issue Jun 4, 2020 · 6 comments · Fixed by #248
Closed

v-model on marker #14

josegus opened this issue Jun 4, 2020 · 6 comments · Fixed by #248
Assignees
@diegoazh
Labels
enhancement Improve an existing functionality requested for the community feature requested A new feature requested for the community released
Projects
gmap-vue

Comments

@josegus
Copy link

josegus commented Jun 4, 2020

Would be nice if we could use v-model with a GmapMarker (along with current :position prop), since everytime I move the marker I need to update manually the new location lat and lng values
@diegoazh
Copy link
Owner

diegoazh commented Jul 30, 2020 •
edited

@josegus that sounds good for me, if you have any idea about how to implement this you are welcome to send your PR. I can analyse it but, I don't have the full time to implement it and it is possible that it would take me some time to land a new release.

@diegoazh diegoazh added the feature requested A new feature requested for the community label Jul 30, 2020
@diegoazh diegoazh added this to To do in gmap-vue via automation Jul 30, 2020
@stale
Copy link

stale bot commented Sep 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 28, 2020
@stale stale bot closed this as completed Oct 5, 2020
gmap-vue automation moved this from To do to Done Oct 5, 2020
@diegoazh diegoazh reopened this Nov 18, 2021
gmap-vue automation moved this from Done to In progress Nov 18, 2021
@stale stale bot removed the wontfix label Nov 18, 2021
@diegoazh diegoazh added the enhancement Improve an existing functionality requested for the community label Nov 26, 2021
@diegoazh diegoazh self-assigned this Nov 26, 2021
@create-issue-branch
Copy link

Branch issue-14-v-model_on_marker created!

@stale
Copy link

stale bot commented Jan 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 26, 2022
@stale stale bot closed this as completed Feb 3, 2022
gmap-vue automation moved this from In progress to Done Feb 3, 2022
@diegoazh diegoazh added WIP work in progress and removed wontfix labels Feb 9, 2022
@diegoazh diegoazh reopened this Feb 9, 2022
gmap-vue automation moved this from Done to In progress Feb 9, 2022
diegoazh added a commit that referenced this issue Feb 15, 2022
@diegoazh
feat(gmap-vue): emit update:position event on markers
fcb94a7 
We emit this event when dragend event if fired from Google Maps API

Fix #14
@diegoazh diegoazh mentioned this issue Feb 15, 2022
Merged
diegoazh added a commit that referenced this issue Feb 15, 2022
@diegoazh
feat(gmap-vue): emit update:position event on markers
3f50387 
We emit this event when dragend event if fired from Google Maps API

Fix #14
gmap-vue automation moved this from In progress to Done Feb 15, 2022
diegoazh added a commit that referenced this issue Feb 15, 2022
@diegoazh
feat(gmap-vue): emit update:position event on markers
6a34bb7 
We emit this event when dragend event if fired from Google Maps API

Fix #14
github-actions bot pushed a commit that referenced this issue Feb 15, 2022
@semantic-release-bot
chore(gmap-vue): 3.1.0 [skip ci]
f2fa4a4 
# [3.1.0](v3.0.0...v3.1.0) (2022-02-15)

### Features

* **gmap-vue:** emit update:position event on markers ([6a34bb7](6a34bb7)), closes [#14](#14)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@diegoazh
Copy link
Owner

@josegus now we have an update:position event on markers, at the moment is not possible to use v-model directive of Vue 2 in this prop but in Vue 3 it will be possible.
I hope that this will be useful, check the documentation for more details.
Regards.

@diegoazh diegoazh removed the WIP work in progress label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegoazh diegoazh

Labels
enhancement Improve an existing functionality requested for the community feature requested A new feature requested for the community released
Projects
No open projects
gmap-vue
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gmap-vue): emit update:position event on markers diegoazh/gmap-vue
2 participants
@diegoazh @josegus