Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add PreserveViewport as a prop for google-kml-layer #148

Closed
zeroedin opened this issue Mar 5, 2021 · 5 comments · Fixed by #250
Closed

Feature: add PreserveViewport as a prop for google-kml-layer #148

zeroedin opened this issue Mar 5, 2021 · 5 comments · Fixed by #250
Assignees
Labels
feature requested A new feature requested for the community released
Projects

Comments

@zeroedin
Copy link

zeroedin commented Mar 5, 2021

Is your feature request related to a problem? Please describe.
Not a problem per say but having to work around it I guess is an annoyance.

I realize you all are working on the version for vue3 and this is most likely the last of your worries. But would be nice to see it incorporated if possible in future versions if anything. I myself have not yet moved to vue 3.

Describe the solution you'd like
Would like to be able to preserveViewport when adding KML to a map with a prop.

<GmapMap id="gmap" ref="mapRef" :center="center" :zoom="zoom" :options="options">
  <google-kml-layer :url="kml" :clickable="false" preserveViewport="true" />
</GmapMap>

Describe alternatives you've considered
This is my work around

  async mounted(){
    await this.$gmapApiPromiseLazy();
    this.$refs.mapRef.$mapPromise.then((map) => {
      new this.google.maps.KmlLayer({
        url: 'https://url-to-kml.com/my.kml',
        preserveViewport: true,
        map: map
      })
    })
  }

Additional context
Add any other context or screenshots about the feature request here.

@zeroedin zeroedin added the feature requested A new feature requested for the community label Mar 5, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 5, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@stale
Copy link

stale bot commented May 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Jan 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 17, 2022
@stale stale bot closed this as completed Jan 26, 2022
@diegoazh diegoazh reopened this Feb 11, 2022
@stale stale bot removed the wontfix label Feb 11, 2022
@diegoazh diegoazh self-assigned this Feb 16, 2022
@create-issue-branch
Copy link

@diegoazh diegoazh added WIP work in progress and removed stand by labels Feb 16, 2022
@diegoazh diegoazh added this to To do in gmap-vue via automation Feb 16, 2022
gmap-vue automation moved this from To do to Done Feb 16, 2022
github-actions bot pushed a commit that referenced this issue Feb 16, 2022
# [3.4.0](v3.3.0...v3.4.0) (2022-02-16)

### Features

* **gmap-vue:** update kml-layer adding all options as props ([d8cb91f](d8cb91f)), closes [#148](#148)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@diegoazh diegoazh removed the WIP work in progress label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature requested A new feature requested for the community released
Projects
No open projects
gmap-vue
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants