Vue 3 #15
Assignees
Labels
enhancement
Improve an existing functionality requested for the community
high
high priority
question
Further information is requested
Projects
Comments
|
Hello @ljcremer, thanks for your question. The answer is a big YES! my first goal is to migrate this plugin to Vue 3 when it is in a stable state. If you would like to contribute to making it possible please let me know. Regards |
diegoazh
added
enhancement
|
I'm definitely going to be watching the project. I dunno how much I'll be able to contribute just from lack of general skill with Vue, but am interested in this project and will try to offer what I can. |
|
@diegoazh Do you know if this has been started. We would like to collaborate on this. If nothing has been done yet we could potentially start looking into it. |
|
@ljcremer no we did not start the migration yet, I would like to have help and collaborators, you are welcomed but first, we need to improve the actual version and planing the migration to not repeat the same errors when this plugin starts, we need a clear structure and definitions in order to get a better plugin and documentation in the future. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Branch issue-15-Vue_3 created! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hello, |
|
Hi @andreavettore I'm currently working on that, my goal is first to land a version with typescript and use the options API and after that work on changes to use the composition API. |
|
@diegoazh sounds good. Thanks a lot! |
diegoazh
added a commit
that referenced
this issue
Jun 1, 2023
diegoazh
added a commit
that referenced
this issue
Jun 1, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
In this way we allow users to be able to override some values or pass new ones when the required options to build any google maps object changes. #15
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
Now using typescript we can know which components has the setMap function and use it only in that components #15
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
I added the prefix gmv to all components and refs, it means GMapVue #15
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
I also improve the map-layer component and its composables to match with street-view-panorama component because they are related in some parts. #15
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
diegoazh
added a commit
that referenced
this issue
Jun 3, 2023
Merged
diegoazh
added a commit
that referenced
this issue
Jun 4, 2023
* fix(gmap-vue-next): fix types, composables, and map-layer component * fix(gmap-vue-next): fix rollup and typescript build and improve its configurations * fix(gmap-vue-next): change to typescript and vite, map layer withoout errors * fix(gmap-vue-next): start adding unit test for composables and preparing all for e2e tests with cypress * fix(gmap-vue-next): fix e2e server and render warnings * fix(gmap-vue-next): fix map-test component example * fix(gmap-vue-next): add e2e test for map-layer component * fix(gmap-vue-next): fix broken unit tests * test(gmap-vue-next): add unit test for promise-lazy-builder and google-maps-promise * fix(gmap-vue-next): fix test:e2e:ci script * chore(gmap-vue): reorganize code inside the map layer component * fix(gmap-vue-next): remove keys from beging exported and update typings on package.json * feat(gmap-vue-next): migrate marker-icon component to composition api using script setup * fix(gmap-vue-next): fix map-layer and marker-icon components and improve the old mapped props * feat(gmap-vue-next): migrate cluster-icon component * feat(gmap-vue-next): migrate cluster-icon component * feat(gmap-vue-next): migrate info-window component * fix(gmap-vue-next): fix ts(7056) on setup script I solved removing from the defineExports function the template ref variable defined inside the setup script. I also fix the ts(4082) error moving the props interface to its own script[lang=ts] tag, this change is needed because I am using the interface on hooks and not only inside script setup but it looks like very ugly. The Vue documentation only said that the interface should be in the same file not in the same script tag. * fix(gmap-vue-next): spread options prop at the end when buid the options In this way we allow users to be able to override some values or pass new ones when the required options to build any google maps object changes. #15 * fix(gmap-vue-next): makes options prop optional #15 * fix(gmap-vue-next): remove unnecesary unmounted hook Now using typescript we can know which components has the setMap function and use it only in that components #15 * fix(gmap-vue-next): small fixes on watch functions #15 * feat(gmap-vue-next): migrate the autocomplete component #15 * chore(gmap-vue): improve component and function names I added the prefix gmv to all components and refs, it means GMapVue #15 * feat(gmap-vue-next): migrate kml-layer component #15 * fix(gmap-vue-next): rename google-maps-promise to map-promise to be more explicit about its content #15 * chore(gmap-vue-next): enable explicitly an option enabled implicitly by other option #15 * fix(gmap-vue-next): update test file name to match with the target tested file #15 * feat(gmap-vue-next): migrate street view panorama I also improve the map-layer component and its composables to match with street-view-panorama component because they are related in some parts. #15 * chore(all): update all dependencies * chore(docs): update api documentation * chore(docs): update api documentation * chore(all): update all dependencies * docs(docs): update api documentation * docs(docs): update api documentation * chore(root): update commitlint rules #15 * fix(gmap-vue-next): update all clases to use the gmv prefix #15 * feat(gmap-vue-next): migrate heatmap-layer component #15 * fix(gmap-vue-next): unify error messages on map-promise #15 * feat(gmap-vue-next): migrate circle-shape componet #15 * fix(gmap-vue-next): remove unnecesary variables and fix typos #15 * feat(gmap-vue-next): migrate polygon-shape component #15 * fix(gmap-vue-next): remove unnecesary macro imports #15 * feat(gmap-vue-next): migrate polilyne shape component #15 * feat(gmap-vue-next): migrate rectangle shape component #15 * feat(gmap-vue-next): migrate drawing manager component #15 * fix(gmap-vue-next): reorder function params to be more consistent #15 * fix(gmap-vue-next): last fixes on types and structures over composables * test(gmap-vue-next): add test files and start writing unit tests * fix(gmap-vue-next): fix final options merge to have always default options * fix(gmap-vue-next): fix components, helpers and composables #15 * test(gmap-vue-next): fix tests after last name changes * chore(gmap-vue-next): remove unused dependencies and unused files * fix(gmap-vue-next): rewrite components to define props with an object instead of an interface * test(gmap-vue-next): fix e2e and unit tests * chore(gmap-vue-next): update file name on types and related imports * chore(gmap-vue-next): update imports of all files * chore(gmap-vue-next): update typings path and dependency versions * chore(gmap-vue-next): update typescript and vite configuration * chore(gmap-vue-next): update dependencies, scripts and pnpm-lock file * chore(root): update dependency versions * chore(gmap-vue-v2): rename gmap-vue to gmap-vue-v2 * chore(gmap-vue-v3): rename gmap-vue-next to gmap-vue-v3 * chore(v2): rename folder gmap-vue-v2 to v2 * chore(v3): rename folder gmap-vue-v3 to v3 * chore(root): update configuration files accordingly to the new repository structure * chore(v3): update plugin verstion to 4.0.0 to support vue v3 * test(v3): update import path on test * chore(v3): update pnpm-lock file, package names on every package.json file and cypress config on v3 path * test(v3): add e2e tests for autocomplete cluster and marker components * chore(v3): remove unused dependencies and update tests * fix(v3): update exports and imports to optimize it * chore(v3): fix typos and e2e runner erros * chore(v3): remove path-exist-cli and update scripts * test(v3): e2e test for info-window added * test(v3): update e2e test for info-window and add tests for circle, rectangle and polyline * fix(v3): update imports and exports and others small fixes * test(v3): update all e2e tests * chore(v3): update gitignore file * chore(v3): update them main readme * chore(v2): updates vue version on package v2 * chore(v2): update scripts on package.json and configuration useful for debug * fix(v3): fix types and exported members from this plugin * chore(v2): update readme with deprecation note * chore(v2): update package name * chore(v3): update package name * chore(v2): add publish config to package * chore(v3): add publish config to package * chore(v3): update all e2e tests with the new plugin structure * chore(root): add test:e2e to the main package and udpate github actions to run e2e tests * chore(v2): udpate readme file * chore(v3): udpate readme file * chore(root): update github actions fixing a typo * chore(root): update github actions to confirm .env file was created * test(v3): improve e2e test using within instead to use should be.visible. --------- Co-authored-by: Diego Alberto Zapata Hantsch <diegoalbertozapatahantsch@Diegos-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you have any plans to convert this to Vue 3?
The text was updated successfully, but these errors were encountered: