-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gmap-vue): add a drawing manager component #19
Conversation
This is a drawing manager component that brings up a UI for drawing shapes on your map. If you leave it empty, it will bring up the default DrawingManager toolbar, but you can also add your own toolbar into the default slot. In this case, slot scoped methods are provided to change the drawing mode, and delete selected shapes. The mandatory shapes prop will contain all the drawn shapes. If this has existing shape data in it, they will be drawn onto the map when the editor is displayed. Please test the examples first!
@davydnorris thanks for this great PR, this weekend I review it, thank you a lot. |
Thank you - the only thing I could not be sure of was the example code because I could not build the examples to test. You may want to also include the zipped example I added to the issue |
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
packages/gmap-vue/src/components-implementation/drawing-manager.js
Outdated
Show resolved
Hide resolved
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
…n/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…n/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…n/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
…/drawing-manager.js
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @davydnorris upgrade the minor version of the
package.json
in one point - please run
npm run lint
and format your with VSCode or Prettier
Awesome work!!!
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Awesome work!!! @davydnorris, I have one question for you, do you like to help |
Congrats @davydnorris, this feature was landed today!!! |
This is a drawing manager component that brings up a UI for drawing shapes on your map. If you leave it empty, it will bring up the default DrawingManager toolbar, but you can also add your own toolbar into the default slot. In this case, slot scoped methods are provided to change the drawing mode, and delete selected shapes.
The mandatory shapes prop will contain all the drawn shapes. If this has existing shape data in it, they will be drawn onto the map when the editor is displayed.
Please test the examples first!