Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gmap-vue): add a drawing manager component #19

Merged
merged 22 commits into from
Aug 2, 2020

Conversation

davydnorris
Copy link

This is a drawing manager component that brings up a UI for drawing shapes on your map. If you leave it empty, it will bring up the default DrawingManager toolbar, but you can also add your own toolbar into the default slot. In this case, slot scoped methods are provided to change the drawing mode, and delete selected shapes.

The mandatory shapes prop will contain all the drawn shapes. If this has existing shape data in it, they will be drawn onto the map when the editor is displayed.

Please test the examples first!

This is a drawing manager component that brings up a UI for drawing
shapes on your map. If you leave it empty, it will bring up the default
DrawingManager toolbar, but you can also add your own toolbar into the
default slot. In this case, slot scoped methods are provided to change
the drawing mode, and delete selected shapes.

The mandatory shapes prop will contain all the drawn shapes. If this has
existing shape data in it, they will be drawn onto the map when the
editor is displayed.

Please test the examples first!
@diegoazh
Copy link
Owner

@davydnorris thanks for this great PR, this weekend I review it, thank you a lot.

@diegoazh diegoazh added ready for reviewers A PR that pass all tests and which is ready for a review code high high priority labels Jul 30, 2020
@davydnorris
Copy link
Author

Thank you - the only thing I could not be sure of was the example code because I could not build the examples to test. You may want to also include the zipped example I added to the issue

@diegoazh diegoazh added this to In progress in gmap-vue via automation Jul 30, 2020
@diegoazh diegoazh moved this from In progress to Review in progress in gmap-vue Jul 30, 2020
@diegoazh diegoazh self-assigned this Aug 1, 2020
@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 1, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

packages/gmap-vue/examples/drawing-manager2.html Outdated Show resolved Hide resolved
packages/gmap-vue/examples/drawing-manager2.html Outdated Show resolved Hide resolved
packages/gmap-vue/examples/drawing-manager2.html Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

1 similar comment
@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Copy link
Owner

@diegoazh diegoazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @davydnorris upgrade the minor version of the package.json in one point
  • please run npm run lint and format your with VSCode or Prettier

Awesome work!!!

gmap-vue automation moved this from Review in progress to Reviewer approved Aug 2, 2020
@ghost
Copy link

ghost commented Aug 2, 2020

There were the following issues with this Pull Request

  • Commit: eea3d2d
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@diegoazh diegoazh merged commit d7afa94 into diegoazh:master Aug 2, 2020
gmap-vue automation moved this from Reviewer approved to Done Aug 2, 2020
@diegoazh
Copy link
Owner

diegoazh commented Aug 2, 2020

Awesome work!!! @davydnorris, I have one question for you, do you like to help GmapVue like a maintainer? Please let me know.
Regards.

@diegoazh
Copy link
Owner

diegoazh commented Aug 3, 2020

Congrats @davydnorris, this feature was landed today!!!
bitmoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core examples high high priority ready for reviewers A PR that pass all tests and which is ready for a review code
Projects
No open projects
gmap-vue
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants