feat(v3): create independent instances of every component using a component key prop #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponent key We added a key to every component to create independent instances for everyone and a default key if you only use one instance of every component and do not want to set the key. Solve: #309
diegoazh
deleted the
issue-309-Bug_Does_not_work_with_multiple_maps_on_the_same_page
branch
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
diegoazh
commented
Apr 14, 2024
Comment on lines
+78
to
+79
| // map.value = await mapPromise; | ||
| // ready.value = true; |
diegoazh
commented
Apr 14, 2024
Comment on lines
+24
to
+25
| const componentPromisesList = new Map(); | ||
| /** |
There was a problem hiding this comment.
Add a blank line between these two lines.
diegoazh
commented
Apr 14, 2024
Comment on lines
+578
to
+579
| let ancestor = currentInstance?.parent; | ||
| let name = ancestor?.type.name || ancestor?.type.__name; |
There was a problem hiding this comment.
Reuse this in a function.
diegoazh
commented
Apr 14, 2024
Comment on lines
+582
to
+583
| ancestor = ancestor.parent; | ||
| name = ancestor?.type.name || ancestor?.type.__name; |
There was a problem hiding this comment.
Reuse this in a function.
diegoazh
commented
Apr 14, 2024
There was a problem hiding this comment.
Fix this file to use the new features correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a key prop to every component to create independent instances for every one of them and we use a default key if you do not want to set the key and only use one instance of every component.
Solve: #309