Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v3): change inject for composable to get component promise #324

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix(v3): change inject for composable to get component promise #324

merged 3 commits into from
Apr 24, 2024

Conversation

diegoazh
Copy link
Owner

The inject key can only be used on descendants, not on siblings. It's more accurate to use composables on the mounted hook.

Solve: #323

@diegoazh
fix(v3): change inject for composable to get component promise
5fee1d9 
The inject key can only be used on descendants not in siblings. Composables on mounted hook are more accurate.

Solve: #323
@diegoazh
test(v3): update cluster test to use the new key feature
d8f1cbe
@diegoazh diegoazh added enhancement Improve an existing functionality requested for the community fix labels Apr 24, 2024
@diegoazh diegoazh self-assigned this Apr 24, 2024
@update-docs Update Docs
Copy link

update-docs bot commented Apr 24, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

@diegoazh diegoazh merged commit 6613c59 into master Apr 24, 2024
12 checks passed
@diegoazh diegoazh deleted the issue-323-Bug_GvmInfoWindow_components_are_not_removed_from_the_map branch April 24, 2024 21:42
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
@semantic-release-bot
chore(v3): 2.1.2 [skip ci]
18e181d 
## [2.1.2](gmv3_v2.1.1...gmv3_v2.1.2) (2024-04-24)

### Bug Fixes

* **v3:** change inject for composable to get component promise  ([#324](#324)) ([6613c59](6613c59)), closes [#323](#323)
@diegoazh
Copy link
Owner Author

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@diegoazh diegoazh

Labels
enhancement Improve an existing functionality requested for the community fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diegoazh