Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showCloseButton is not true by default #200

Closed
stevemao opened this issue Sep 8, 2018 · 3 comments · Fixed by #229
Closed

showCloseButton is not true by default #200

stevemao opened this issue Sep 8, 2018 · 3 comments · Fixed by #229

Comments

@stevemao
Copy link
Contributor

stevemao commented Sep 8, 2018

Not sure if this is a bug or docs not updated yet. I'm using the lastest react-redux-toastr published on npm.

@diegoddox
Copy link
Owner

Because of inactivity I will close this issue but feel free to reopen in case you feel that this has to be addressed.

@stevemao
Copy link
Contributor Author

I wasn't sure if which should be fixed: docs or code. Once you give the direction I can submit a PR.

@diegoddox
Copy link
Owner

Hi @stevemao, it will be a good help if you could update the docs.
Thanks in advance.

stevemao added a commit to stevemao/react-redux-toastr that referenced this issue May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants