Display years and author titles in reconciliation suggestions #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to get item authors/years as part of the reconcilation response? Additionally, is it possible to get the author's name for an entity without first getting that entity, seeing if it has an author name string or author property, then getting the author entity if needed? |
Needs an extra query to get this information after reconciliation returns suggested qids
Dominic-DallOsto
force-pushed
the
Dominic-DallOsto/issue103
branch
from
89f586f
to
038c5d4
Compare
|
Overall this seems to work nicely. Having the year and author information is helpful to disambiguate between potential matches. It was mentioned in #52 that providing author and year information in the query should automatically result in us getting it back, but this doesn't seem to be the case. Instead we just get back the matching score for each feature individually, as well as for the item as a whole. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Fixes #52