Rewrite #2
Merged
Rewrite #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `flowArgs` option instead of `interfacesPath` option -- more generic * Run `flow status` even if flow server was started externally * Print `flow stop` and `flow start` output so user can see what's going on * Don't rerun `flow status` if webpack rebuilds before last `flow status` finishes * Print Flow output with its nice `--color always` formatting
This was referenced Mar 14, 2016
diegodurli
added a commit
that referenced
this pull request
Mar 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this plugin!
This fork has various improvements:
FlowStatusPluginconstructor. This is a very unexpected side effect. If a config script constructs aFlowStatusPluginbut for whatever reason decides not to include it in the exported webpack config, the developer would not want any side effects to occur. (Side effects in constructors are a well-documented antipattern)flowArgsoption instead ofinterfacesPathoption -- use can instead pass--lib path/to/interfacesalong with any other args they want (I updated the example in the README)flow statuseven if flow server was started externallyflow stopandflow startoutput so user can see what's going onflow statusif webpack rebuilds before lastflow statusfinishes--color alwaysformatting