Breaking API change to support base type comparison.

[diegofrata]

Equals made protected and IEquatable made explicit for classes. This should sort out the last issue with comparing derived types cast as base-type.

Solves #43

[diegofrata]

@christianrondeau are you happy with this fix? I have added a new test case specific to the stack overflow issue you had:

https://github.com/diegofrata/Generator.Equals/blob/575c48698102113f12334170b38ae7ec777dbbdd/Generator.Equals.Tests/Classes/OverridingEquals.Sample.cs

Everything looks good to me. If it looks good to you, then I will cut 3.0.0 so you can carry on using it.

[christianrondeau]

I'm looking at the branch, is that the eventual 3.0? And FYI I got this when referencing directly from source, it's annoying when you don't have VS installed :D

You could check for an environment variable, or a precompiler directive other than DEBUG.

So, I had this that you may find interesting:

new protected member declared in sealed type

If you add a test case with a sealed class using Equatable, it'll say that you may as well mark the method as private.

Which also makes me realize you should add <generated /> at the beginning of your generated files so the IDE knows it's a generated file.

[diegofrata]

@christianrondeau I have fixed the private/protected modifier and added extra tests. On the <generated/> comment I could not find any guidelines or docs for use -- I am not entirely sure this does anything that's not already accomplished by the GeneratedCodeAttribute.

If you have any pointers to it, let me know.

[diegofrata]

These changes are available on 3.0.0-beta001 if you want to give that a go!

[christianrondeau]

You may be right, anyway I also got it wrong, it's actually <auto-generated />
https://learn.microsoft.com/en-us/dotnet/csharp/roslyn-sdk/source-generators-overview does it but doesn't explain why... I guess it's just to make it clear. But I guess it doesn't really matters.

I'll pull and try it when I have some time :)