Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override __define_qt5_base instead of _define_qt_base #4

Open
halil3d opened this issue Jul 22, 2021 · 0 comments
Open

Override __define_qt5_base instead of _define_qt_base #4

halil3d opened this issue Jul 22, 2021 · 0 comments

Comments

@halil3d
Copy link
Contributor

halil3d commented Jul 22, 2021

def _define_qt_base(self):

Overriding _define_qt_base is probably not as explicit as overriding __define_qt5_base which should also work during an engine init to grab the goods from PyQt5 if a valid base is returned.

Though this could be removed along with the PyQt5Patcher if the following PR on tk-core is accepted and merged in: shotgunsoftware/tk-core#815 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant