Skip to content

Commit

Permalink
refactor: delete manual interfaces for changelogs (eclipse-edc#1728)
Browse files Browse the repository at this point in the history
* cleanup: delete manual interfaces for changelogs
  • Loading branch information
janpmeyer authored and diegogomez-zf committed Aug 3, 2022
1 parent 382c639 commit afa312f
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 488 deletions.
3 changes: 1 addition & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,5 @@ Closes # <-- _insert Issue number if one exists_
- [ ] added/updated copyright headers?
- [ ] documented public classes/methods?
- [ ] added/updated relevant documentation?
- [ ] added relevant details to the changelog? (_skip with label `no-changelog`_)
- [ ] assigned appropriate label? (_mandatory_)
- [ ] assigned appropriate label? (exclude from changelog with label `no-changelog`)
- [ ] formatted title correctly? (_take a look at the [CONTRIBUTING](https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/main/CONTRIBUTING.md#submit-a-pull-request) and [styleguide](https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/main/styleguide.md) for details_)
12 changes: 0 additions & 12 deletions .github/workflows/scan-pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,6 @@ concurrency:
cancel-in-progress: true

jobs:
check-for-changelog-modifications:
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v3
- name: Check for new entries
uses: brettcannon/check-for-changed-files@v1
with:
file-pattern: 'CHANGELOG.md'
skip-label: 'no-changelog'
failure-message: 'Missing changes in CHANGELOG.md. Please add relevant information if needed.'

check-pull-request-title:
runs-on: ubuntu-latest
continue-on-error: false
Expand Down
Loading

0 comments on commit afa312f

Please sign in to comment.