[redux] Error when Google/Facebook script wasn't loaded

[tashburn]

Thanks for creating this. I just starting playing with it and it looks fantastic.

I downloaded the fullstack branch code, ran yarn, then yarn run dev.

The browser at localhost:3000 throws an exception:

utils.js:215 uncaught at _default 
 at _default 
 at watchSocialLoginGoogle 
 at prepareGoogle 
 TypeError: Cannot read property 'load' of undefined
    at eval (webpack:///./src/store/social/sagas.js?:47:18)
    at loadGoogleAuth2 (webpack:///./src/store/social/sagas.js?:46:12)
    at runCallEffect (webpack:///./~/redux-saga/lib/internal/proc.js?:501:19)
    at runEffect (webpack:///./~/redux-saga/lib/internal/proc.js?:429:399)
    at next (webpack:///./~/redux-saga/lib/internal/proc.js?:310:9)
    at currCb (webpack:///./~/redux-saga/lib/internal/proc.js?:383:7)

I'm on MacOS 10.12.1 and using Chrome Version 55.0.2883.95 (64-bit). # @

[diegohaz]

Hi, @tashburn. Thanks for the report. I tried to reproduce it (also on MacOS 10.12.1 and Chrome 55), but I couldn't see the error.

It seems to be related to this snippet on src/store/social/sagas.js:

  loadGoogleAuth2: () => new Promise((resolve) => {
    window.gapi.load('auth2', resolve)
  })

Something went wrong while loading google script and window.gapi was not set.

Does this only happen on fullstack? That code also exists on the redux branch.

[tashburn]

Mmm. Sounds likely that it's something peculiar on my side then. Thanks for checking it out.

[diegohaz]

Added a verification to get rid of this error in 7d3cad0

[diegohaz]

Reopening as I'm still seeing an uncaught error.

[diegohaz]

Fixed in #98