[universal-redux] Upgrading to react-router 4.x #195

kybarg · 2017-03-28T04:02:15Z

closes #161

codecov-io · 2017-03-28T04:19:16Z

Codecov Report

Merging #195 into universal-redux will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           universal-redux   #195    +/-   ##
===============================================
  Coverage              100%   100%            
===============================================
  Files                    9     75    +66     
  Lines                  308    732   +424     
  Branches                92    171    +79     
===============================================
+ Hits                   308    732   +424

Impacted Files	Coverage Δ
src/components/atoms/Button/index.js	`100% <ø> (ø)`
...rc/components/molecules/PrimaryNavigation/index.js	`100% <ø> (ø)`
src/components/atoms/Link/index.js	`100% <ø> (ø)`
src-clean/store/selectors.js
.storybook/config.js
src-clean/store/sagas.js
src-clean/store/reducer.js
src-clean/store/actions.js
src-clean/components/index.js
src/components/atoms/Atom/index.js	`100% <0%> (ø)`
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667c030...ae42549. Read the comment docs.

See [here](https://github.com/ReactTraining/react-router/tree/master/packages/react-router-config)

diegohaz · 2017-03-28T13:12:20Z

Awesome, @kybarg

Will review that asap

diegohaz · 2017-03-28T20:22:18Z

package.json

@@ -49,11 +49,11 @@
    "nodemon": "^1.11.0",
    "opn-cli": "^3.1.0",
    "react-addons-test-utils": "^15.4.1",
+    "react-hot-loader": "^3.0.0-beta.6",


react-hot-loader needs to be a production dependency. The library itself handles production/development properly.

diegohaz · 2017-03-28T20:25:16Z

package.json

    "cross-env": "^3.1.4",
    "csurf": "^1.9.0",
    "express": "^4.14.0",
    "express-force-ssl": "^0.3.2",
    "file-loader": "^0.10.0",
-    "history": "3.0.0",
+    "history": "^4.6.1",
+    "isomorphic-fetch": "^2.2.1",


Could you please make that change (replacing axios by isomorphic-fetch) on another PR? It's actually a bug we missed.

@diegohaz done

diegohaz · 2017-03-28T20:27:19Z

src-clean/client.js

-const baseHistory = useRouterHistory(createHistory)({ basename })
-const store = configureStore(initialState, baseHistory)
-const history = syncHistoryWithStore(baseHistory, store)
+const history = createHistory()


What about basename?

diegohaz · 2017-03-28T20:31:10Z

src-clean/server.js

-          component &&
-          component[method] &&
-          promises.push(component[method]({ req, res, params, location, store }))
+  const fetchData = () => new Promise((resolve, reject) => {


How does fetchData work now? Is that still asynchronous?

@diegohaz @kybarg I'm testing this out right now. Everything looks A ok 👍 When I make a post, I get this error Encountered two children with the same key, 1:$101``

Is that expected?

@protoEvangelion Can't reproduce on test environment. Could you please provide more details?

@diegohaz Sure, nothing changed in general. Only react-router match logic has changed.

@kybarg Sorry for the delay! This was not an issue with the upgrade. The problem existed before the upgrade. It has to do with the front end adding identical keys when creating a new post. I will address this after React-Router-4 is merged :)

diegohaz · 2017-04-01T01:22:23Z

Thank you, @kybarg ❤️

Will review that this weekend.

Geczy · 2017-04-04T14:10:29Z

How'd the review go @diegohaz

kybarg · 2017-04-08T14:18:25Z

@diegohaz Any updates or your are closing this branch in favor for redux-ssr?

diegohaz · 2017-04-08T14:38:46Z

I still didn't find time to proper review that. Will do as soon as possible.

Geczy · 2017-04-11T17:07:02Z

Can you delegate anyone else to review this? Seems like you don't have much time to, would prefer quicker updates

diegohaz · 2017-04-11T17:11:50Z

@Geczy It's open for anyone who wants to test it. The boilerplate itself doesn't need to be updated for people update their projects. Please, try @kybarg's branch and give your feedback.

Geczy · 2017-04-13T15:50:55Z

Thanks for keeping this branch up to date @kybarg

kybarg · 2017-04-14T11:10:05Z

@Geczy You are welcome 😄

Geczy · 2017-04-17T14:21:30Z

@kybarg can you merge the latest redux branch?
Edit: noticed you're on the universal branch, so maybe you can't

Geczy · 2017-04-17T16:01:10Z

Running yarn storybook I get this error on all the Page books:

Cannot read property 'route' of undefined
TypeError: Cannot read property 'route' of undefined
    at Route.computeMatch (webpack:///./~/react-router/Route.js?:68:22)
    at new Route (webpack:///./~/react-router/Route.js?:47:20)
    at eval (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:295:18)
    at measureLifeCyclePerf (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:75:12)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:294:16)
    at ReactCompositeComponentWrapper._constructComponent (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:280:21)
    at ReactCompositeComponentWrapper.mountComponent (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:188:21)
    at Object.mountComponent (webpack:///./~/react-dom/lib/ReactReconciler.js?:46:35)
    at ReactCompositeComponentWrapper.performInitialMount (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:371:34)
    at ReactCompositeComponentWrapper.mountComponent (webpack:///./~/react-dom/lib/ReactCompositeComponent.js?:258:21)

kybarg · 2017-04-17T22:09:54Z

@Geczy redux or redux-ssr?

Geczy · 2017-04-18T00:05:23Z

kybarg:univeral-redux-rr4

Geczy · 2017-04-20T14:18:48Z

what's the word @kybarg

protoEvangelion · 2017-04-21T00:19:02Z

@kybarg @Geczy Shouldn't we merge this into the redux-ssr branch because universal-redux is phasing out?

diegohaz · 2017-04-21T00:29:18Z

I'm looking into this right now. Brace yourselves, merge is coming.

diegohaz · 2017-04-21T03:24:34Z

Sorry for the delay and thank you very much, @kybarg and everyone. I fixed the problem with pages in storybook.

The current redux-ssr is experimental (it's actually broken right now). universal-redux is still the official branch. I just need to take a moment to get it up to date with master/redux. Any help is welcome.

kybarg added 2 commits March 28, 2017 07:00

Upgrading to react-router 4.x

520ed48

Moved react-hot-loader to devDependencies

27e125b

kybarg changed the title ~~Upgrading ot react-router 4.x~~ Upgrading to react-router 4.x Mar 28, 2017

Fixed Link test

c08e820

kybarg added 3 commits March 28, 2017 09:48

Nested data fetch on server

3e908e4

See [here](https://github.com/ReactTraining/react-router/tree/master/packages/react-router-config)

Fixed errors

17d18b9

Fixed lint

d13a8a4

diegohaz changed the title ~~Upgrading to react-router 4.x~~ [universal-redux] Upgrading to react-router 4.x Mar 28, 2017

diegohaz reviewed Mar 28, 2017

View reviewed changes

protoEvangelion mentioned this pull request Mar 31, 2017

Style Loader #188

Open

History basename support, fetchData - changed url to path

656b1ee

Merge branch 'universal-redux' into univeral-redux-rr4

16ecebc

Geczy mentioned this pull request Apr 1, 2017

Upgrade to React Router 4 #161

Closed

Switched to stable react-router packages

a705b9a

kybarg added 3 commits April 12, 2017 20:23

Using renderRoutes function

8d74163

Fixed lint

5a602fd

Updated react-router packages

ae42549

diegohaz merged commit ae42549 into diegohaz:universal-redux Apr 21, 2017

kybarg deleted the univeral-redux-rr4 branch January 6, 2019 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[universal-redux] Upgrading to react-router 4.x #195

[universal-redux] Upgrading to react-router 4.x #195

kybarg commented Mar 28, 2017 •

edited

codecov-io commented Mar 28, 2017 •

edited

diegohaz commented Mar 28, 2017

diegohaz Mar 28, 2017

diegohaz Mar 28, 2017

kybarg Mar 31, 2017

diegohaz Mar 28, 2017

diegohaz Mar 28, 2017

protoEvangelion Mar 30, 2017

kybarg Mar 31, 2017

kybarg Mar 31, 2017

protoEvangelion Apr 3, 2017

diegohaz commented Apr 1, 2017

Geczy commented Apr 4, 2017

kybarg commented Apr 8, 2017

diegohaz commented Apr 8, 2017 •

edited

Geczy commented Apr 11, 2017

diegohaz commented Apr 11, 2017

Geczy commented Apr 13, 2017

kybarg commented Apr 14, 2017

Geczy commented Apr 17, 2017 •

edited

Geczy commented Apr 17, 2017

kybarg commented Apr 17, 2017

Geczy commented Apr 18, 2017

Geczy commented Apr 20, 2017

protoEvangelion commented Apr 21, 2017

diegohaz commented Apr 21, 2017

diegohaz commented Apr 21, 2017 •

edited

[universal-redux] Upgrading to react-router 4.x #195

[universal-redux] Upgrading to react-router 4.x #195

Conversation

kybarg commented Mar 28, 2017 • edited

codecov-io commented Mar 28, 2017 • edited

Codecov Report

diegohaz commented Mar 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diegohaz commented Apr 1, 2017

Geczy commented Apr 4, 2017

kybarg commented Apr 8, 2017

diegohaz commented Apr 8, 2017 • edited

Geczy commented Apr 11, 2017

diegohaz commented Apr 11, 2017

Geczy commented Apr 13, 2017

kybarg commented Apr 14, 2017

Geczy commented Apr 17, 2017 • edited

Geczy commented Apr 17, 2017

kybarg commented Apr 17, 2017

Geczy commented Apr 18, 2017

Geczy commented Apr 20, 2017

protoEvangelion commented Apr 21, 2017

diegohaz commented Apr 21, 2017

diegohaz commented Apr 21, 2017 • edited

kybarg commented Mar 28, 2017 •

edited

codecov-io commented Mar 28, 2017 •

edited

diegohaz commented Apr 8, 2017 •

edited

Geczy commented Apr 17, 2017 •

edited

diegohaz commented Apr 21, 2017 •

edited