Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed functions to add support for editor extensions #11

Merged
merged 10 commits into from Sep 22, 2017

Conversation

Dennitz
Copy link
Contributor

@Dennitz Dennitz commented Jul 4, 2017

  • moved actual replication step of replicate into separate function in utils.js
  • added option to pass in the current working directory for some of the util functions (because process.cwd() doesn't work for vscode extensions)
  • exposed utils.js so that its functions can be used by other modules
  • added typescript definition file for those functions (only the ones i used in vscode-generact)

@codecov-io
Copy link

codecov-io commented Jul 4, 2017

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          31     57   +26     
  Branches        4      8    +4     
=====================================
+ Hits           31     57   +26
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6bce85...6671c48. Read the comment docs.

@diegohaz
Copy link
Owner

diegohaz commented Jul 4, 2017

Thank you, @Dennitz. Will take a look at this as soon as possible.

@diegohaz diegohaz merged commit 813f746 into diegohaz:master Sep 22, 2017
@diegohaz
Copy link
Owner

Hi, @Dennitz. Thank you for your work and I'm sorry for the huge delay.

I've just renamed performReplication to replicate.

Released in v0.3.0.

Will send a PR to your repo later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants