We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Using default 72dpi and millimeters then printing it out and measuring leads to wrong sizes.
To Reproduce
See https://react-pdf.org/repl?code=3187b0760ce02e00408a057025803c450298c0bc300500943807cf805030c00f0022230080b6198531165d400a02180e659a004f003619b006f61622003a0046200099080be309467908fbb4e9ca80150c29634f152a288c72005861e9a013ba8066a8312bdfb3803f1800c24e0e984a3000ee4850b630c13cc05000b4000e4aae30be1cfa5400f4c6a6ded9f966566292e67298a6aa853e001218c0b63c10003430c90836ed36502d1dc1006e2cc048e0dd30602030008ec810d3fc083c4e4a2b308c008710305048188cc98b1de34e593e2c3018ae1850d310081d2c103c8cfbac20ed3cc9c1509b604a10188603c2b88844d3112835c3c111f5665d180012e444f480f1e4a0b9861cefa66b0000b7a0cb861518c04003ee8f3eaac786000178f1da100c1f0005f602b938e930084edf8dcc198c76d8b44bd31b8ce26820f88c139da502e938ee22c44b19c18467ca601024181b9f4f1aaab007757ac8420ed02d8d92ca3300056206e5386016cd020d6c69d4f0f61018700e5b21800134411002732f51a75b2456981053c9c0b30283617c0a4f16d1a4123cf5983028c00cf9c8b6eb39a294d29f6bcac10a6c1876866363c0023dd29920d60d9b3a8a5113dad8acdcb4114e9a6979201db0161082724f273d8db77c7002904088c6ccac0ad1885eceed94fd07bf29c8c16ab4b30f79120f70b793046000257a1eae99876a757aa087b3751a043974d0282019426b0f48c3de3c3d2b782059a382b1f01d9dcbb8ea8f1420ca821691c2e9421d12af08c2220bcfb852302804e372a88bc1b9eeb0991af11c59a809c9f0dc80204aea8c34ccc7e6772ba208888a1ce86beec30bacc591083fc047c44806e6b184cd3c8449660a74c3f1eaa3324630263fb689734a1808041800b2fd37c2c11eb58e9249fe0c771cb252359c1d45407ba91c933caf3bc7c66014520f2188ed05a7d08803a22d849ca00d6302d84828cc3b66f6bac5093120330185ac5721cc10bc00373f1ae222a2b024294c09ae1cc1714e12058a22e56253ba382013118ac2621cec14220d991e02b84eb30154606e960d3a62e09cafda4c4809c7da82600cd9a329a0b212b1c1a7bf41242d603b29c98ded5ca20015586017c495d3115c3bb44a512fb84d833ac4d44059a0574b4e6d2f55c64c2030c7678d1d67c3a946070fc363129ca92570400c202d74b4f0a8ad865e8f0d897538226e1884a62c9060028b400ba79e89bc2c0aa315c5095ce9c9ec8abc80e0ba9703c598fc2032485aea77015678ec9d156eab4c5b0ec3f8420c372dd4c0e818b06b16027a62987e73a740b36659aca49b6e1b7896d44d73a2e1a730bae8a772c62c97c301206f1f445a72e3a4b93966e49340ba8a2d01213ac5f17ec54d6ebb722a88dda098804a02572727caf2015ce5ea8559b02f9912601e361d8e5814227b73302bd05b9e629b511e1cb553869fee679805768759be6ef087220e82b385a9c5d8065c82f8ba44ee7a98cc76f510c133a960733ec6e4008c000716658547483a637aa1f45bc5324661d880f4ba76f8b3c362a8a8a3fbede0b4cd8938fd931c1108fcf8b9726f5d3ef3deead02ddb85a38c9dde670cac2ce2d24ab9314b525046098251ac394528361642c6010000e4981d3170b11d51ca490780240747e0180a04413940a9d02c25e0020762a8220d81481e02cc0000c0009048701683a05ca75039060250bb8a15704d8550a43250103701e0c20e45a8b91587785c874018065360640081e53206400018b80280b21821f0240d00e51208e0308de088210000b86000072000f2101c22c2250fa22f2500804e1801e8fd1b60a0140648100744e41c8fd5581c83e0404f6300590ff8720401c89394c4882503910630f000cc391830007d430001a4001a80036100a3c003a8fd7900015494144c6071200068004e1e0001042a6c8471ae1f4590021522c83316803a8404ec5c00019440674fb0b71fc5c44c0ea3283d8470728f44487384703998c3007623102c5ae9802c47055096333b285d1301267e858c4a0ab0ed430accec400260000c8c1180acdd98e00e5f000042e81909d8a89172ae7acca07b2ee5d42744810d2b0584a72002b25ceb9300d64706a1e826044ca99938a22ccf99f21164206591f260078a809d2fe4603d1c3c4e7a2c508e3d29e8d79e8ac42b82807a2ce7a29aa7c01c752f45550a00548dc7c0e641880c5d89c182ca0a00211383b1ac586982885941996c2fd04259c1d8e1e972751022406115eb00000d6a2a1a648e918f81c0242e034064628f814e0f0150440a81d01603e15aa80000
The page has a horizontal padding of 25mm to the paper. Printing it out and measuring it ends up at 28-29mm.
I am not sure where this number for calculating comes from?
react-pdf/packages/stylesheet/src/transform/units.js
Line 33 in fab09cc
Expected behavior Specifying mm as units should print the exact size when printing
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
Using default 72dpi and millimeters then printing it out and measuring leads to wrong sizes.
To Reproduce
See https://react-pdf.org/repl?code=3187b0760ce02e00408a057025803c450298c0bc300500943807cf805030c00f0022230080b6198531165d400a02180e659a004f003619b006f61622003a0046200099080be309467908fbb4e9ca80150c29634f152a288c72005861e9a013ba8066a8312bdfb3803f1800c24e0e984a3000ee4850b630c13cc05000b4000e4aae30be1cfa5400f4c6a6ded9f966566292e67298a6aa853e001218c0b63c10003430c90836ed36502d1dc1006e2cc048e0dd30602030008ec810d3fc083c4e4a2b308c008710305048188cc98b1de34e593e2c3018ae1850d310081d2c103c8cfbac20ed3cc9c1509b604a10188603c2b88844d3112835c3c111f5665d180012e444f480f1e4a0b9861cefa66b0000b7a0cb861518c04003ee8f3eaac786000178f1da100c1f0005f602b938e930084edf8dcc198c76d8b44bd31b8ce26820f88c139da502e938ee22c44b19c18467ca601024181b9f4f1aaab007757ac8420ed02d8d92ca3300056206e5386016cd020d6c69d4f0f61018700e5b21800134411002732f51a75b2456981053c9c0b30283617c0a4f16d1a4123cf5983028c00cf9c8b6eb39a294d29f6bcac10a6c1876866363c0023dd29920d60d9b3a8a5113dad8acdcb4114e9a6979201db0161082724f273d8db77c7002904088c6ccac0ad1885eceed94fd07bf29c8c16ab4b30f79120f70b793046000257a1eae99876a757aa087b3751a043974d0282019426b0f48c3de3c3d2b782059a382b1f01d9dcbb8ea8f1420ca821691c2e9421d12af08c2220bcfb852302804e372a88bc1b9eeb0991af11c59a809c9f0dc80204aea8c34ccc7e6772ba208888a1ce86beec30bacc591083fc047c44806e6b184cd3c8449660a74c3f1eaa3324630263fb689734a1808041800b2fd37c2c11eb58e9249fe0c771cb252359c1d45407ba91c933caf3bc7c66014520f2188ed05a7d08803a22d849ca00d6302d84828cc3b66f6bac5093120330185ac5721cc10bc00373f1ae222a2b024294c09ae1cc1714e12058a22e56253ba382013118ac2621cec14220d991e02b84eb30154606e960d3a62e09cafda4c4809c7da82600cd9a329a0b212b1c1a7bf41242d603b29c98ded5ca20015586017c495d3115c3bb44a512fb84d833ac4d44059a0574b4e6d2f55c64c2030c7678d1d67c3a946070fc363129ca92570400c202d74b4f0a8ad865e8f0d897538226e1884a62c9060028b400ba79e89bc2c0aa315c5095ce9c9ec8abc80e0ba9703c598fc2032485aea77015678ec9d156eab4c5b0ec3f8420c372dd4c0e818b06b16027a62987e73a740b36659aca49b6e1b7896d44d73a2e1a730bae8a772c62c97c301206f1f445a72e3a4b93966e49340ba8a2d01213ac5f17ec54d6ebb722a88dda098804a02572727caf2015ce5ea8559b02f9912601e361d8e5814227b73302bd05b9e629b511e1cb553869fee679805768759be6ef087220e82b385a9c5d8065c82f8ba44ee7a98cc76f510c133a960733ec6e4008c000716658547483a637aa1f45bc5324661d880f4ba76f8b3c362a8a8a3fbede0b4cd8938fd931c1108fcf8b9726f5d3ef3deead02ddb85a38c9dde670cac2ce2d24ab9314b525046098251ac394528361642c6010000e4981d3170b11d51ca490780240747e0180a04413940a9d02c25e0020762a8220d81481e02cc0000c0009048701683a05ca75039060250bb8a15704d8550a43250103701e0c20e45a8b91587785c874018065360640081e53206400018b80280b21821f0240d00e51208e0308de088210000b86000072000f2101c22c2250fa22f2500804e1801e8fd1b60a0140648100744e41c8fd5581c83e0404f6300590ff8720401c89394c4882503910630f000cc391830007d430001a4001a80036100a3c003a8fd7900015494144c6071200068004e1e0001042a6c8471ae1f4590021522c83316803a8404ec5c00019440674fb0b71fc5c44c0ea3283d8470728f44487384703998c3007623102c5ae9802c47055096333b285d1301267e858c4a0ab0ed430accec400260000c8c1180acdd98e00e5f000042e81909d8a89172ae7acca07b2ee5d42744810d2b0584a72002b25ceb9300d64706a1e826044ca99938a22ccf99f21164206591f260078a809d2fe4603d1c3c4e7a2c508e3d29e8d79e8ac42b82807a2ce7a29aa7c01c752f45550a00548dc7c0e641880c5d89c182ca0a00211383b1ac586982885941996c2fd04259c1d8e1e972751022406115eb00000d6a2a1a648e918f81c0242e034064628f814e0f0150440a81d01603e15aa80000
The page has a horizontal padding of 25mm to the paper. Printing it out and measuring it ends up at 28-29mm.
I am not sure where this number for calculating comes from?
react-pdf/packages/stylesheet/src/transform/units.js
Line 33 in fab09cc
Expected behavior
Specifying mm as units should print the exact size when printing
The text was updated successfully, but these errors were encountered: