-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gap between top of the action bar and page content #172
Comments
Try to reproduce the issue on a minimum sample code, then paste the code here. |
Not sure if this code is minimal enough. I think it is my code that is causing it actually. Maybe the Expanded is stretching it out:
|
No, that's not minimal, try creating a new file from empty project,
something that I could run here and reproduce the issue.
…On Sat, Dec 25, 2021, 1:14 PM Benjamin Farquhar ***@***.***> wrote:
Not sure if this code is minimal enough. I think it is my code that is
causing it actually. Maybe the Expanded is stretching it out:
return [
Expanded(
child: KeyboardActions(
tapOutsideBehavior: TapOutsideBehavior.opaqueDismiss,
config: KeyboardActionsConfig(
defaultDoneWidget: const VpKeyboardDoneButton(),
actions: [
KeyboardActionsItem(
focusNode: focusNodeName,
),
KeyboardActionsItem(
focusNode: focusNodeLocationName,
),
KeyboardActionsItem(
focusNode: focusNodeCompanyName,
),
KeyboardActionsItem(
focusNode: focusNodeDescription,
),
],
),
child: Column(mainAxisSize: MainAxisSize.min, children: [
nameTextField(context: context!, form: form),
locationNameTextField(context: context, form: form!),
companyNameTextField(context: context, form: form),
descriptionTextField(context: context, vm: vm),
])))
];
—
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3UA526H54JUM7ADW7EDUSYCYTANCNFSM5KYAPMHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
I am having trouble with that. But if this helps, it doesn't have the gap when I do |
I'm pretty sure it is this: #48 It seems like a bug with autoscroll. |
If I have anything that takes up space below my |
It is a bug. When you calculate the offset to "avoid" EG:
It calculates the action bar height (45) + the device keyboard height:
The |
Would you mind creating a PR to fix this issue? :D |
@diegoveloper Sure, I will give it a go |
@diegoveloper I have tried to push to my new branch "benjamin-farquhar/bug/172-fix-offset"; however, access is denied. Do you need to permit me? |
You need to fork the project then send a PR
…On Sun, Dec 26, 2021, 3:43 PM Benjamin Farquhar ***@***.***> wrote:
@diegoveloper <https://github.com/diegoveloper> I have tried to push to
my new branch "benjamin-farquhar/bug/172-fix-offset"; however, access is
denied. Do you need to permit me?
—
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3UDPCOIHAXGWWEMSXLDUS5475ANCNFSM5KYAPMHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* #172 Fix gap between actions bar and page content Fix a bug where if anything was below the KeyboardActions widget, it created a gap between the actions bar and page content * Test with dialogs * remove red testing background * Fix bug pointed out by Diegoveloper in Sample 3 * Add Sample 5 to show bug behaviour
…effects (#176) Also tested in landscape mode which is now working (it wouldn't have before because _widgetHeight used to be only set once)
Please see https://stackoverflow.com/a/64473806/3935156 for details on why there was so many inconsistencies in behaviour
* #172 apply offset fix to dialogs * Make more null safe, someone was experiencing a null reference exception
* #172 Fix bugs found in "avoid" offset after more testing (#177) Please see https://stackoverflow.com/a/64473806/3935156 for details on why there was so many inconsistencies in behaviour * validation added * #172 apply offset fix to dialogs (#178) * Full null reference exception (#180) * #172 apply offset fix to dialogs * Make more null safe, someone was experiencing a null reference exception * new version ready * nit: clean readme Co-authored-by: Benjamin Farquhar <bt.farquhar@gmail.com>
flutter_keyboard_actions is adding a gap between the keyboard action bar and my page content. How can I make my page content go all the way down to the keyboard action bar?
The text was updated successfully, but these errors were encountered: