Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linearGradientBackgroundColor param for LinearPercentIndicator #114

Merged
merged 3 commits into from Mar 24, 2021

Conversation

jeremiahlukus
Copy link
Contributor

I removed the .idea folder from git as there were tons for modifications since i use iintellij.

There were some other auto generated code in
example/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata
and
percent_indicator.iml

I can remove these diffs if you want again this was auto generated by intellij.

Copy link
Owner

@diegoveloper diegoveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good. Can you add a new sample inside the example project with this new parameter?

@jeremiahlukus
Copy link
Contributor Author

@diegoveloper done

Copy link
Owner

@diegoveloper diegoveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegoveloper
Copy link
Owner

Thanks for the contribution @jeremiahlukus

@diegoveloper diegoveloper merged commit 5c07fd4 into diegoveloper:master Mar 24, 2021
diegoveloper added a commit that referenced this pull request Mar 24, 2021
* version updated

* Add linearGradientBackgroundColor param for LinearPercentIndicator (#114)

* Jeremiah-Parrack | add linearGradientBackgroundColor param for LinearPercentIndicator

* Jeremiah-Parrack | remove idea from git

* Jeremiah-Parrack | add linearGradient exaample

Co-authored-by: Jeremiah-Parrack <jeremiah.parrack@coxautoinc.com>

* changelog updated

Co-authored-by: Jeremiah Parrack <jeremiahlukus1@gmail.com>
Co-authored-by: Jeremiah-Parrack <jeremiah.parrack@coxautoinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants