Set up Diem ID Domains on mini wallet startup #306

sunmilee · 2021-06-01T19:20:38Z

Add domains to parent vasp account on-chain during wallet startup
Read events to create a domain id -> on-chain address mapping
Add payment metadata function

src/diem/testing/cli.py

src/diem/testing/miniwallet/app/app.py

src/diem/testing/miniwallet/app/event_puller.py

src/diem/testing/miniwallet/config.py

src/diem/testnet.py

src/diem/testing/miniwallet/app/models.py

src/diem/jsonrpc/client.py

src/diem/utils.py

src/diem/jsonrpc/client.py

src/diem/testing/miniwallet/config.py

src/diem/testing/suites/conftest.py

xli · 2021-06-11T18:46:16Z

src/diem/testing/suites/conftest.py

@@ -48,7 +49,9 @@ def stub_wallet_app(start_stub_wallet: Tuple[AppConfig, App]) -> App:

 @pytest.fixture(scope="package")
 def start_stub_wallet(diem_client: jsonrpc.Client) -> Tuple[AppConfig, App]:
-    conf = AppConfig(name="stub-wallet", server_conf=ServerConfig(**dmw_stub_server()))
+    conf = AppConfig(
+        name="stubwallet", server_conf=ServerConfig(**dmw_stub_server()), diem_id_domain=dmw_stub_diem_id_domain()


I think we probably should keep original name "stub-wallet", don't see a reason to rename it.

mini-wallet.md

tests/miniwallet/conftest.py

xli · 2021-06-11T18:56:28Z

I suggest we split this PR into:

generate new code from diem core for new PaymentMetadata and other data structures. this PR should be easy to review and land as you only include generated code and maybe txnmetadata.py change (add a test for it)
change to jsonrpc/client get_diem_id_domain_map, and faucet#mint, also need add a test for them.
add an option to testing/cli.py for customizing the diem-id-domain, including test_testing_cli to confirm it is good.
miniwallet changes, generate dynamic diem id domain for starting app in test env, create a test to confirm the diem id is handled properly. current implementation only handle the reference id set on txn.

xli · 2021-06-11T22:17:07Z

I suggest we split this PR into:

generate new code from diem core for new PaymentMetadata and other data structures. this PR should be easy to review and land as you only include generated code and maybe txnmetadata.py change (add a test for it)

change to jsonrpc/client get_diem_id_domain_map, and faucet#mint, also need add a test for them.

add an option to testing/cli.py for customizing the diem-id-domain, including test_testing_cli to confirm it is good.

miniwallet changes, generate dynamic diem id domain for starting app in test env, create a test to confirm the diem id is handled properly. current implementation only handle the reference id set on txn.

Or combine first 3 together, as they are pretty much finished in this PR.

src/diem/testnet.py

tests/miniwallet/conftest.py

src/diem/testing/suites/conftest.py

src/diem/testing/cli.py

src/diem/testing/suites/conftest.py

src/diem/jsonrpc/client.py

sunmilee force-pushed the miniwallet branch from a4bdce2 to cc47e92 Compare June 1, 2021 19:57

sunmilee marked this pull request as ready for review June 1, 2021 23:17

sunmilee force-pushed the miniwallet branch from cc47e92 to efe0395 Compare June 1, 2021 23:18

sunmilee requested a review from xli June 1, 2021 23:18

sunmilee force-pushed the miniwallet branch 3 times, most recently from 324eec0 to 6d23f01 Compare June 2, 2021 02:32

xli reviewed Jun 2, 2021

View reviewed changes

sunmilee force-pushed the miniwallet branch 4 times, most recently from 154e987 to 16be7b9 Compare June 4, 2021 01:58

SunMi Lee added 2 commits June 3, 2021 19:35

Set up Diem ID Domains on mini wallet startup

7bc4c94

comments

f2bffe3

sunmilee force-pushed the miniwallet branch 3 times, most recently from c4b2845 to 9762ad4 Compare June 10, 2021 06:07

After refactor

c0318e5

sunmilee force-pushed the miniwallet branch from 9762ad4 to c0318e5 Compare June 11, 2021 09:25

sunmilee requested a review from xli June 11, 2021 09:26

Remove storage logic

5f39a9e

sunmilee force-pushed the miniwallet branch from b42c9e3 to 5f39a9e Compare June 11, 2021 09:55

xli reviewed Jun 11, 2021

View reviewed changes

Handle faucet domain error

2b0f2b3

sunmilee force-pushed the miniwallet branch from 6237493 to 2b0f2b3 Compare June 14, 2021 20:55

sunmilee requested a review from xli June 14, 2021 20:55

xli reviewed Jun 14, 2021

View reviewed changes

src/diem/testnet.py Outdated Show resolved Hide resolved

tests/miniwallet/conftest.py Outdated Show resolved Hide resolved

src/diem/testing/suites/conftest.py Outdated Show resolved Hide resolved

xli reviewed Jun 15, 2021

View reviewed changes

src/diem/testing/suites/conftest.py Outdated Show resolved Hide resolved

sunmilee requested a review from xli June 15, 2021 22:42

sunmilee force-pushed the miniwallet branch 2 times, most recently from a8cb4df to 8e4f53e Compare June 15, 2021 22:45

xli reviewed Jun 16, 2021

View reviewed changes

Remove CLI functions

0c11dc6

sunmilee force-pushed the miniwallet branch from 8e4f53e to 0c11dc6 Compare June 16, 2021 00:27

xli reviewed Jun 16, 2021

View reviewed changes

src/diem/jsonrpc/client.py Show resolved Hide resolved

Add test

f12d33f

xli approved these changes Jun 16, 2021

View reviewed changes

sunmilee merged commit cc1a00d into diem:master Jun 16, 2021

This was referenced Jun 22, 2021

Diem ID Payment in Miniwallet with E2E Test #309

Merged

Diem ID #291

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up Diem ID Domains on mini wallet startup #306

Set up Diem ID Domains on mini wallet startup #306

sunmilee commented Jun 1, 2021 •

edited

xli Jun 11, 2021

xli commented Jun 11, 2021

xli commented Jun 11, 2021

Set up Diem ID Domains on mini wallet startup #306

Set up Diem ID Domains on mini wallet startup #306

Conversation

sunmilee commented Jun 1, 2021 • edited

xli Jun 11, 2021

Choose a reason for hiding this comment

xli commented Jun 11, 2021

xli commented Jun 11, 2021

sunmilee commented Jun 1, 2021 •

edited