Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[state sync] reduce error verbosity #1707

Closed
wants to merge 1 commit into from
Closed

[state sync] reduce error verbosity #1707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions state-synchronizer/src/coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,12 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
StateSynchronizerMsg_oneof::ChunkRequest(request) => {
let known_version = request.known_version;
if let Err(err) = self.process_chunk_request(peer_id, request).await {
error!("[state sync] failed to serve chunk request to {} with known version {}: {:?}", peer_id, known_version, err);
error!("[state sync] failed to serve chunk request to {} with known version {}: {}", peer_id, known_version, err);
}
}
StateSynchronizerMsg_oneof::ChunkResponse(response) => {
if let Err(err) = self.process_chunk_response(&peer_id, response).await {
error!("[state sync] failed to process chunk response from {}: {:?}", peer_id, err);
error!("[state sync] failed to process chunk response from {}: {}", peer_id, err);
counters::OP_COUNTERS.inc(&format!("{}.{}", counters::APPLY_CHUNK_FAILURE, peer_id));
} else {
self.peer_manager.update_score(&peer_id, PeerScoreUpdateType::Success);
Expand All @@ -179,7 +179,7 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
_ => {}
}
},
Err(err) => { error!("[state sync] network error {:?}", err); },
Err(err) => { error!("[state sync] network error {}", err); },
}
},
_ = interval.select_next_some() => {
Expand Down Expand Up @@ -238,7 +238,7 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
}
}
if let Err(err) = self.check_subscriptions().await {
error!("[state sync] failed to check subscriptions: {:?}", err);
error!("[state sync] failed to check subscriptions: {}", err);
}
}
let sync_request_complete = self.sync_request.as_ref().map_or(false, |sync_req| {
Expand Down Expand Up @@ -276,7 +276,7 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
|| request.limit > self.config.max_chunk_limit
{
return Err(format_err!(
"[state sync] timeout: {:?}, chunk limit: {:?}, but timeout must not exceed {:?} ms, and chunk limit must not exceed {:?}",
"[state sync] timeout: {}, chunk limit: {}, but timeout must not exceed {} ms, and chunk limit must not exceed {}",
request.timeout,
request.limit,
self.config.max_timeout_ms,
Expand All @@ -295,7 +295,7 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
_ => latest_ledger_info.clone(),
};

debug!("[state sync] chunk request: peer_id: {:?}, known_version: {}, latest_ledger_info: {}, target: {}", peer_id, request.known_version, latest_ledger_info.ledger_info().version(), target.ledger_info().version());
debug!("[state sync] chunk request: peer_id: {}, known_version: {}, latest_ledger_info: {}, target: {}", peer_id, request.known_version, latest_ledger_info.ledger_info().version(), target.ledger_info().version());

// if upstream synchronizer doesn't have new data and request timeout is set
// add peer request into subscription queue
Expand Down Expand Up @@ -478,7 +478,7 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
}
};
debug!(
"[state sync] request next chunk. peer_id: {:?}, known_version: {}, timeout: {}",
"[state sync] request next chunk. peer_id: {}, known_version: {}, timeout: {}",
peer_id,
self.known_version + offset,
timeout
Expand Down Expand Up @@ -539,7 +539,7 @@ impl<T: ExecutorProxyTrait> SyncCoordinator<T> {
}
while let Some(res) = futures.next().await {
if let Err(err) = res {
error!("[state sync] failed to notify subscriber {:?}", err);
error!("[state sync] failed to notify subscriber {}", err);
}
}
Ok(())
Expand Down