Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] refactoring for code readability #252

Closed
wants to merge 1 commit into from

Conversation

designe
Copy link

@designe designe commented Jul 6, 2019

Motivation

Refactoring for code readability in config

Have you read the Contributing Guidelines on pull requests?

YES

Test Plan

rustfmt and
unit test is passed on config

Related PRs

N/A

@huitseeker
Copy link
Contributor

Thanks!

We currently run rustfmt with reorder_imports but are not strict on ordering between lines/groups at the moment. If we decided to do so, a tool-based approach that would maintain the ordering of imports would be more sustainable than a one-off, and required for a repository of this size.

We'll be tracking rustfmt evolutions on the issue, thanks for raising attention on this.

@huitseeker huitseeker closed this Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants