[types] Add macro to auto-derive TryFrom for VM errors
#4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariorussi-zz
approved these changes
Jun 23, 2020
|
@bors-libra r=dariorussi |
|
📌 Commit 633b27d has been approved by |
|
Cluster Test Result Repro cmd: |
|
☀️ Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by: rust-lang/rfcs#2783 (comment) that allowed the implementation of
TryFromfor an enum, this implements this with some slight changes: In particular to have proper error messages, and to allow testing of the try-from that is derived from it to make sure that it is behaving as expected.