Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] update comment about transaction expiration times #5767

Merged
merged 1 commit into from Aug 25, 2020

Conversation

bob-wilson
Copy link
Contributor

After #5674, the maximum value for transaction expiration is no longer constrained by a factor of 1_000_000, so update the comment to reflect that.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

@bob-wilson
Copy link
Contributor Author

/land

@bors-libra bors-libra moved this from In Review to Queued in bors Aug 25, 2020
After diem#5674, the maximum value for transaction expiration is no
longer constrained by a factor of 1_000_000, so update the comment
to reflect that.

Closes: diem#5767
@bors-libra bors-libra moved this from Queued to Testing in bors Aug 25, 2020
@github-actions
Copy link

Cluster Test Result

Compatibility test results for land_0e945e2e ==> land_759dc06a (PR)
1. All instances running land_0e945e2e, generating some traffic on network
2. First validator land_0e945e2e ==> land_759dc06a, to validate storage
3. First batch validators (14) land_0e945e2e ==> land_759dc06a, to test consensus
4. Second batch validators (15) land_0e945e2e ==> land_759dc06a, to upgrade rest of the validators
5. All full nodes (30) land_0e945e2e ==> land_759dc06a, to finish the network upgrade
all up : 995 TPS, 4545 ms latency, 5500 ms p99 latency, no expired txns
Logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2020-08-25T22:26:03Z',to:'2020-08-25T22:51:50Z'))
Dashboard: http://grafana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/d/2XqUIhnWz/performance?from=1598394363000&to=1598395910000
Validator 1 logs: http://kibana.ct-2-k8s-testnet.aws.hlw3truzy4ls.com/app/kibana#/discover?_g=(time:(from:'2020-08-25T22:26:03Z',to:'2020-08-25T22:51:50Z'))&_a=(columns:!(log),query:(language:kuery,query:'kubernetes.pod_name:"val-1"'),sort:!(!('@timestamp',desc)))

Repro cmd:

./scripts/cti --tag land_0e945e2e --cluster-test-tag land_759dc06a -E RUST_LOG=debug -E BATCH_SIZE=15 -E UPDATE_TO_TAG=land_759dc06a --report report.json --suite land_blocking_compat

@bors-libra bors-libra removed this from Testing in bors Aug 25, 2020
@bors-libra bors-libra merged commit 759dc06 into diem:master Aug 25, 2020
@bob-wilson bob-wilson deleted the txn-expiration-comment branch August 25, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants